Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1478)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py

Issue 2678773003: Make wpt-import --auto-update pass if the issue is closed after CQ. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py
index 7c47ebccffea4a03e6ca6a001739b7552ee7dd64..b747083bad878a1023d7ca45958b93e579b30634 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py
@@ -47,6 +47,18 @@ class GitCLTest(unittest.TestCase):
git_cl = GitCL(host)
self.assertEqual(git_cl.get_issue_number(), 'None')
+ def test_is_closed_true(self):
+ host = MockHost()
+ host.executive = MockExecutive(output='closed ')
jeffcarp 2017/02/06 22:58:45 Should there be a space at the end of closed?
qyearsley 2017/02/06 23:15:38 I put that there to test whether it's OK to have w
+ git_cl = GitCL(host)
+ self.assertTrue(git_cl.is_closed())
+
+ def test_is_closed_false(self):
+ host = MockHost()
+ host.executive = MockExecutive(output='waiting')
+ git_cl = GitCL(host)
+ self.assertFalse(git_cl.is_closed())
+
def test_all_jobs_finished_empty(self):
self.assertTrue(GitCL.all_jobs_finished([]))

Powered by Google App Engine
This is Rietveld 408576698