Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Unified Diff: content/browser/service_worker/embedded_worker_test_helper.h

Issue 2678733002: [ServiceWorker] Mojofy ActivateEvent of Service Worker (Closed)
Patch Set: Address comments #25, #26, #33 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/embedded_worker_test_helper.h
diff --git a/content/browser/service_worker/embedded_worker_test_helper.h b/content/browser/service_worker/embedded_worker_test_helper.h
index 094032b43407845bae7fa818ea4ebb29e612ca3e..0d2a2ca0f38485a04315675567d92c138530cf80 100644
--- a/content/browser/service_worker/embedded_worker_test_helper.h
+++ b/content/browser/service_worker/embedded_worker_test_helper.h
@@ -65,6 +65,7 @@ struct ServiceWorkerFetchRequest;
class EmbeddedWorkerTestHelper : public IPC::Sender,
public IPC::Listener {
public:
+ enum class Event { Activate };
using FetchCallback =
base::Callback<void(ServiceWorkerStatusCode,
base::Time /* dispatch_event_time */)>;
@@ -126,6 +127,9 @@ class EmbeddedWorkerTestHelper : public IPC::Sender,
// Inner IPC sink for script context messages sent via EmbeddedWorker.
IPC::TestSink* inner_ipc_sink() { return &inner_sink_; }
+ const std::vector<Event>& dispatched_events() const { return events_; }
+ std::vector<Event>* events_ptr() { return &events_; }
falken 2017/02/15 07:32:03 Having both a const& and ptr is a bit unusual and
xiaofengzhang 2017/02/16 06:17:50 Done.
+
std::vector<std::unique_ptr<MockEmbeddedWorkerInstanceClient>>*
mock_instance_clients() {
return &mock_instance_clients_;
@@ -183,7 +187,9 @@ class EmbeddedWorkerTestHelper : public IPC::Sender,
// OnMessageToWorker when events are sent to the embedded
// worker. By default they just return success via
// SimulateSendReplyToBrowser.
- virtual void OnActivateEvent(int embedded_worker_id, int request_id);
+ virtual void OnActivateEvent(
+ const mojom::ServiceWorkerEventDispatcher::DispatchActivateEventCallback&
+ callback);
virtual void OnExtendableMessageEvent(
mojom::ExtendableMessageEventPtr event,
const mojom::ServiceWorkerEventDispatcher::
@@ -239,7 +245,9 @@ class EmbeddedWorkerTestHelper : public IPC::Sender,
void OnMessageToWorkerStub(int thread_id,
int embedded_worker_id,
const IPC::Message& message);
- void OnActivateEventStub(int request_id);
+ void OnActivateEventStub(
+ const mojom::ServiceWorkerEventDispatcher::DispatchActivateEventCallback&
+ callback);
void OnExtendableMessageEventStub(
mojom::ExtendableMessageEventPtr event,
const mojom::ServiceWorkerEventDispatcher::
@@ -308,6 +316,8 @@ class EmbeddedWorkerTestHelper : public IPC::Sender,
std::vector<scoped_refptr<MessagePortMessageFilter>>
message_port_message_filters_;
+ std::vector<Event> events_;
+
base::WeakPtrFactory<EmbeddedWorkerTestHelper> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(EmbeddedWorkerTestHelper);

Powered by Google App Engine
This is Rietveld 408576698