Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 2678733002: [ServiceWorker] Mojofy ActivateEvent of Service Worker (Closed)
Patch Set: Rebase and address shimazu, falken and peter's comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_context_client.cc
diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc
index 670835798d90fd5099d78b59e28ab4d88ffb5426..c871c54d360490a476c587264304190ebc38e837 100644
--- a/content/renderer/service_worker/service_worker_context_client.cc
+++ b/content/renderer/service_worker/service_worker_context_client.cc
@@ -205,6 +205,8 @@ struct ServiceWorkerContextClient::WorkerContextData {
IDMap<std::unique_ptr<blink::WebServiceWorkerClientCallbacks>>;
using SkipWaitingCallbacksMap =
IDMap<std::unique_ptr<blink::WebServiceWorkerSkipWaitingCallbacks>>;
+ using ActivateEventCallbacksMap =
+ IDMap<std::unique_ptr<const DispatchActivateEventCallback>>;
using SyncEventCallbacksMap = IDMap<std::unique_ptr<const SyncCallback>>;
using PaymentRequestEventCallbacksMap =
IDMap<std::unique_ptr<const PaymentRequestEventCallback>>;
@@ -243,6 +245,9 @@ struct ServiceWorkerContextClient::WorkerContextData {
// Pending callbacks for ClaimClients().
ClaimClientsCallbacksMap claim_clients_callbacks;
+ // Pending callbacks for Activate Events.
+ ActivateEventCallbacksMap activate_event_callbacks;
+
// Pending callbacks for Background Sync Events.
SyncEventCallbacksMap sync_event_callbacks;
@@ -419,7 +424,6 @@ void ServiceWorkerContextClient::OnMessageReceived(
CHECK_EQ(embedded_worker_id_, embedded_worker_id);
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(ServiceWorkerContextClient, message)
- IPC_MESSAGE_HANDLER(ServiceWorkerMsg_ActivateEvent, OnActivateEvent)
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_InstallEvent, OnInstallEvent)
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_DidGetClient, OnDidGetClient)
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_DidGetClients, OnDidGetClients)
@@ -583,6 +587,7 @@ void ServiceWorkerContextClient::willDestroyWorkerContext(
proxy_ = NULL;
// Aborts all the pending events callbacks.
+ AbortPendingEventCallbacks(context_->activate_event_callbacks);
AbortPendingEventCallbacks(context_->sync_event_callbacks);
AbortPendingEventCallbacks(context_->notification_click_event_callbacks);
AbortPendingEventCallbacks(context_->notification_close_event_callbacks);
@@ -668,9 +673,12 @@ void ServiceWorkerContextClient::didHandleActivateEvent(
int request_id,
blink::WebServiceWorkerEventResult result,
double event_dispatch_time) {
- Send(new ServiceWorkerHostMsg_ActivateEventFinished(
- GetRoutingID(), request_id, result,
- base::Time::FromDoubleT(event_dispatch_time)));
+ const DispatchActivateEventCallback* callback =
+ context_->activate_event_callbacks.Lookup(request_id);
+ DCHECK(callback);
+ callback->Run(EventResultToStatus(result),
+ base::Time::FromDoubleT(event_dispatch_time));
+ context_->activate_event_callbacks.Remove(request_id);
}
void ServiceWorkerContextClient::didHandleExtendableMessageEvent(
@@ -944,9 +952,12 @@ void ServiceWorkerContextClient::SetRegistrationInServiceWorkerGlobalScope(
WebServiceWorkerRegistrationImpl::CreateHandle(registration));
}
-void ServiceWorkerContextClient::OnActivateEvent(int request_id) {
+void ServiceWorkerContextClient::DispatchActivateEvent(
+ const DispatchActivateEventCallback& callback) {
TRACE_EVENT0("ServiceWorker",
- "ServiceWorkerContextClient::OnActivateEvent");
+ "ServiceWorkerContextClient::DispatchActivateEvent");
+ int request_id = context_->activate_event_callbacks.Add(
+ base::MakeUnique<DispatchActivateEventCallback>(callback));
proxy_->dispatchActivateEvent(request_id);
}

Powered by Google App Engine
This is Rietveld 408576698