Issue 267873004: Remove unused VIEW_ID_FIND_IN_PAGE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 267873004: Remove unused VIEW_ID_FIND_IN_PAGE. (Closed)

Created:
6 years, 7 months ago by msw

Modified:
6 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove unused VIEW_ID_FIND_IN_PAGE. VIEW_ID_FIND_IN_PAGE_TEXT_FIELD is used and tested. This alternate id isn't actually useful or tested. BUG=NONE TEST=No find bar behavior changes or regressions. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268008

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -8 lines)			Patch
M	chrome/browser/ui/cocoa/find_bar/find_bar_view.mm	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/cocoa/view_id_util_browsertest.mm	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/view_ids.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/find_bar_view.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

msw

Hey Scott please take a look; thanks. (cleanup found while working on ui tests)

6 years, 7 months ago (2014-05-02 20:11:42 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/267873004/1

6 years, 7 months ago (2014-05-02 22:17:11 UTC) #4

Message was sent while issue was closed.

Change committed as 268008