Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 267873002: [Android]: Update Makefile.android to use platform-14 as minimum. (Closed)

Created:
6 years, 7 months ago by rmcilroy
Modified:
6 years, 7 months ago
Reviewers:
ulan
CC:
v8-dev, marja
Visibility:
Public.

Description

[Android]: Update Makefile.android to use platform-14 as minimum. The version of the NDK in Chromium only has platform/android-14 and above (since Chrome only supports API 14 and above). To make it easier for developers to use the Chromium NDK to build V8, this CL updates the default platform version to 14. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21159

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Makefile.android View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmcilroy
I don't think this should affect the bots, but please let me know if the ...
6 years, 7 months ago (2014-05-02 15:13:25 UTC) #1
ulan
lgtm, bots use Android NDK r9, which has platform-14.
6 years, 7 months ago (2014-05-05 11:10:47 UTC) #2
rmcilroy
On 2014/05/05 11:10:47, ulan wrote: > lgtm, bots use Android NDK r9, which has platform-14. ...
6 years, 7 months ago (2014-05-06 09:08:07 UTC) #3
rmcilroy
6 years, 7 months ago (2014-05-06 09:08:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r21159 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698