Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 2678683002: Delay instantiating InputDeviceCapabilities until accessed. (Closed)
Patch Set: rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
index 6c6dd72073cbb288c3dfe87b70bfb4e2e8da2ba4..a3fa288220acc44f6ae270c01d87ede421803208 100644
--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
@@ -3464,7 +3464,8 @@ TEST_P(WebViewTest, TextInputFlags) {
toHTMLInputElement(document->getElementById("input"));
document->setFocusedElement(
inputElement,
- FocusParams(SelectionBehaviorOnFocus::None, WebFocusTypeNone, nullptr));
+ FocusParams(SelectionBehaviorOnFocus::None, WebFocusTypeNone,
+ InputDeviceCapabilities::Null));
webViewImpl->setFocus(true);
WebTextInputInfo info1 = activeInputMethodController->textInputInfo();
EXPECT_EQ(WebTextInputFlagAutocompleteOff | WebTextInputFlagAutocorrectOff |
@@ -3477,7 +3478,8 @@ TEST_P(WebViewTest, TextInputFlags) {
inputElement = toHTMLInputElement(document->getElementById("input2"));
document->setFocusedElement(
inputElement,
- FocusParams(SelectionBehaviorOnFocus::None, WebFocusTypeNone, nullptr));
+ FocusParams(SelectionBehaviorOnFocus::None, WebFocusTypeNone,
+ InputDeviceCapabilities::Null));
webViewImpl->setFocus(true);
WebTextInputInfo info2 = activeInputMethodController->textInputInfo();
EXPECT_EQ(WebTextInputFlagAutocompleteOn | WebTextInputFlagAutocorrectOn |
@@ -3491,7 +3493,8 @@ TEST_P(WebViewTest, TextInputFlags) {
toHTMLTextAreaElement(document->getElementById("textarea"));
document->setFocusedElement(
textAreaElement,
- FocusParams(SelectionBehaviorOnFocus::None, WebFocusTypeNone, nullptr));
+ FocusParams(SelectionBehaviorOnFocus::None, WebFocusTypeNone,
+ InputDeviceCapabilities::Null));
webViewImpl->setFocus(true);
WebTextInputInfo info3 = activeInputMethodController->textInputInfo();
EXPECT_EQ(WebTextInputFlagAutocapitalizeSentences, info3.flags);
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698