third_party/WebKit/Source/core/input/EventHandler.cpp - Issue 2678683002: Delay instantiating InputDeviceCapabilities until accessed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 2678683002: Delay instantiating InputDeviceCapabilities until accessed. (Closed)

Patch Set: rebased Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/input/EventHandler.cpp

diff --git a/third_party/WebKit/Source/core/input/EventHandler.cpp b/third_party/WebKit/Source/core/input/EventHandler.cpp

index 4736b6f40f03d686d1f7509a07dd3201de6c3eb0..b25e14234bf719b47de2301fcb4d8f9da188e10a 100644

--- a/third_party/WebKit/Source/core/input/EventHandler.cpp

+++ b/third_party/WebKit/Source/core/input/EventHandler.cpp

@@ -677,11 +677,7 @@ WebInputEventResult EventHandler::handleMousePressEvent(

selectionController().initializeSelectionState();

HitTestResult hitTestResult = EventHandlingUtil::hitTestResultInFrame(

m_frame, documentPoint, HitTestRequest::ReadOnly);

- InputDeviceCapabilities* sourceCapabilities =

- m_frame->document()

- ->domWindow()

- ->getInputDeviceCapabilities()

- ->firesTouchEvents(mouseEvent.fromTouch());

+ InputDeviceCapabilitiesValue sourceCapabilities(mouseEvent.fromTouch());

if (eventResult == WebInputEventResult::NotHandled) {

eventResult = m_mouseEventManager->handleMouseFocus(hitTestResult,