third_party/WebKit/Source/core/events/KeyboardEvent.cpp - Issue 2678683002: Delay instantiating InputDeviceCapabilities until accessed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/events/KeyboardEvent.cpp

Issue 2678683002: Delay instantiating InputDeviceCapabilities until accessed. (Closed)

Patch Set: rebased Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/events/KeyboardEvent.cpp

diff --git a/third_party/WebKit/Source/core/events/KeyboardEvent.cpp b/third_party/WebKit/Source/core/events/KeyboardEvent.cpp

index e7581e89641e43fe8bd7ffc3d7428ece99f9be6b..3c8a20e74c9888b68ddf01cb5b4dc438419a065a 100644

--- a/third_party/WebKit/Source/core/events/KeyboardEvent.cpp

+++ b/third_party/WebKit/Source/core/events/KeyboardEvent.cpp

@@ -97,9 +97,7 @@ KeyboardEvent::KeyboardEvent(const WebKeyboardEvent& key,

static_cast<PlatformEvent::Modifiers>(key.modifiers()),

TimeTicks::FromSeconds(key.timeStampSeconds()),

- domWindow

- ? domWindow->getInputDeviceCapabilities()->firesTouchEvents(false)

- : nullptr),

+ InputDeviceCapabilities::None),

m_keyEvent(WTF::makeUnique<WebKeyboardEvent>(key)),

// TODO(crbug.com/482880): Fix this initialization to lazy initialization.

m_code(Platform::current()->domCodeStringFromEnum(key.domCode)),