Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: third_party/WebKit/Source/core/html/forms/InputTypeView.cpp

Issue 2678683002: Delay instantiating InputDeviceCapabilities until accessed. (Closed)
Patch Set: rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
6 * rights reserved. 6 * rights reserved.
7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
8 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 8 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
9 * Copyright (C) 2009, 2010, 2011, 2012 Google Inc. All rights reserved. 9 * Copyright (C) 2009, 2010, 2011, 2012 Google Inc. All rights reserved.
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 64
65 void InputTypeView::forwardEvent(Event*) {} 65 void InputTypeView::forwardEvent(Event*) {}
66 66
67 void InputTypeView::dispatchSimulatedClickIfActive(KeyboardEvent* event) const { 67 void InputTypeView::dispatchSimulatedClickIfActive(KeyboardEvent* event) const {
68 if (element().isActive()) 68 if (element().isActive())
69 element().dispatchSimulatedClick(event); 69 element().dispatchSimulatedClick(event);
70 event->setDefaultHandled(); 70 event->setDefaultHandled();
71 } 71 }
72 72
73 void InputTypeView::accessKeyAction(bool) { 73 void InputTypeView::accessKeyAction(bool) {
74 element().focus( 74 element().focus(FocusParams(SelectionBehaviorOnFocus::Reset, WebFocusTypeNone,
75 FocusParams(SelectionBehaviorOnFocus::Reset, WebFocusTypeNone, nullptr)); 75 InputDeviceCapabilities::Null));
76 } 76 }
77 77
78 bool InputTypeView::shouldSubmitImplicitly(Event* event) { 78 bool InputTypeView::shouldSubmitImplicitly(Event* event) {
79 return event->isKeyboardEvent() && 79 return event->isKeyboardEvent() &&
80 event->type() == EventTypeNames::keypress && 80 event->type() == EventTypeNames::keypress &&
81 toKeyboardEvent(event)->charCode() == '\r'; 81 toKeyboardEvent(event)->charCode() == '\r';
82 } 82 }
83 83
84 HTMLFormElement* InputTypeView::formForSubmission() const { 84 HTMLFormElement* InputTypeView::formForSubmission() const {
85 return element().form(); 85 return element().form();
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 bool InputTypeView::hasBadInput() const { 182 bool InputTypeView::hasBadInput() const {
183 return false; 183 return false;
184 } 184 }
185 185
186 DEFINE_TRACE(ClickHandlingState) { 186 DEFINE_TRACE(ClickHandlingState) {
187 visitor->trace(checkedRadioButton); 187 visitor->trace(checkedRadioButton);
188 EventDispatchHandlingState::trace(visitor); 188 EventDispatchHandlingState::trace(visitor);
189 } 189 }
190 190
191 } // namespace blink 191 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698