Add support for merging results from plugins

Add support for merging results from plugins

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/ccdf574d491d8dc9eb3b950ea3b05f7b83d521ac

[Brian Wilkerson, 2017-02-05 19:14:34]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-02-05 20:11:02]

LGTM

https://codereview.chromium.org/2678673002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/plugin/result_merger.dart (right):

https://codereview.chromium.org/2678673002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/plugin/result_merger.dart:71:
mergedFixes[mergedFixes.indexOf(mergedFix)] = copiedFix;
Maybe we could use just map and return fixesMap.values.toList() at the end.

https://codereview.chromium.org/2678673002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/plugin/result_merger.dart:221: new
List<NavigationRegion>.from(base.regions);
BTW, base.regions.toList() would be easier.

[Brian Wilkerson, 2017-02-06 15:11:29]

https://codereview.chromium.org/2678673002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/plugin/result_merger.dart (right):

https://codereview.chromium.org/2678673002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/plugin/result_merger.dart:71:
mergedFixes[mergedFixes.indexOf(mergedFix)] = copiedFix;
The question is: does the client use the order of the fixes when presenting the
list to the user? I think I was assuming that the order matters so we'd need to
preserve the order as much as possible. But if that's not necessary, then you're
right that we don't need the list.

https://codereview.chromium.org/2678673002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/plugin/result_merger.dart:221: new
List<NavigationRegion>.from(base.regions);
I keep forgetting that `toList` *always* creates a copy. I'll fix all of the
`from`s, but probably in a separate CL.

[scheglov, 2017-02-06 17:18:40]

https://codereview.chromium.org/2678673002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/plugin/result_merger.dart (right):

https://codereview.chromium.org/2678673002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/plugin/result_merger.dart:71:
mergedFixes[mergedFixes.indexOf(mergedFix)] = copiedFix;
On 2017/02/06 15:11:29, Brian Wilkerson wrote:
> The question is: does the client use the order of the fixes when presenting
the
> list to the user? I think I was assuming that the order matters so we'd need
to
> preserve the order as much as possible. But if that's not necessary, then
you're
> right that we don't need the list.

Yes, the order matters.
We sort fixes and assists by their FixKind.relevance and want IDEs to show them
in this sorted order.
Which means, that once sorted, we lost this information and we cannot merge
lists of fixes and keep required sorting between lists. Maybe we should add
relevance to items.

[Brian Wilkerson, 2017-02-07 16:06:40]

https://codereview.chromium.org/2678673002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/plugin/result_merger.dart (right):

https://codereview.chromium.org/2678673002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/plugin/result_merger.dart:71:
mergedFixes[mergedFixes.indexOf(mergedFix)] = copiedFix;
> Maybe we should add relevance to items.

I think that's a good idea. I'll do that in a follow-on CL.

[Brian Wilkerson, 2017-02-07 16:07:05]

Description was changed from

==========
Add support for merging results from plugins
==========

to

==========
Add support for merging results from plugins

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ccdf574d491d8dc9eb3b950ea3b05f7b83d521ac
==========

[Brian Wilkerson, 2017-02-07 16:07:06]

Committed patchset #1 (id:1) manually as
ccdf574d491d8dc9eb3b950ea3b05f7b83d521ac (presubmit successful).