fix dartanalyzer sdk setup

fix dartanalyzer sdk setup

Separate analysis options initialization from context setup
so that analysis options can be used to correctly setup the SDK
in strong mode.

Fix https://github.com/dart-lang/sdk/issues/28507

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/167107e94c7b02272f1e316d4d06c9c66b9a6bbe

[danrubel, 2017-02-04 16:43:28]

Description was changed from

==========
fix dartanalyzer sdk setup

Separate analysis options initialization from context setup
so that analysis options can be used to correctly setup the SDK
in strong mode.
==========

to

==========
fix dartanalyzer sdk setup

Separate analysis options initialization from context setup
so that analysis options can be used to correctly setup the SDK
in strong mode.

Fix https://github.com/dart-lang/sdk/issues/28507
==========

[danrubel, 2017-02-04 16:46:33]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2017-02-04 16:58:38]

lgtm

https://codereview.chromium.org/2678633002/diff/1/pkg/analyzer_cli/lib/src/dr...
File pkg/analyzer_cli/lib/src/driver.dart (right):

https://codereview.chromium.org/2678633002/diff/1/pkg/analyzer_cli/lib/src/dr...
pkg/analyzer_cli/lib/src/driver.dart:372: AnalysisOptions analysisOptions) {
We should document that analysisOptions can / will be null when
includeSdkResolver is false.

[danrubel, 2017-02-04 17:08:34]

https://codereview.chromium.org/2678633002/diff/1/pkg/analyzer_cli/lib/src/dr...
File pkg/analyzer_cli/lib/src/driver.dart (right):

https://codereview.chromium.org/2678633002/diff/1/pkg/analyzer_cli/lib/src/dr...
pkg/analyzer_cli/lib/src/driver.dart:372: AnalysisOptions analysisOptions) {
On 2017/02/04 16:58:38, Brian Wilkerson wrote:
> We should document that analysisOptions can / will be null when
> includeSdkResolver is false.

Good point. Done.

[danrubel, 2017-02-04 17:08:57]

Description was changed from

==========
fix dartanalyzer sdk setup

Separate analysis options initialization from context setup
so that analysis options can be used to correctly setup the SDK
in strong mode.

Fix https://github.com/dart-lang/sdk/issues/28507
==========

to

==========
fix dartanalyzer sdk setup

Separate analysis options initialization from context setup
so that analysis options can be used to correctly setup the SDK
in strong mode.

Fix https://github.com/dart-lang/sdk/issues/28507

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/167107e94c7b02272f1e316d4d06c9c66b9a6bbe
==========

[danrubel, 2017-02-04 17:08:58]

Committed patchset #3 (id:40001) manually as
167107e94c7b02272f1e316d4d06c9c66b9a6bbe (presubmit successful).