Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 267863007: Remove the WebWidget::paint override in fullscreen pepper. (Closed)

Created:
6 years, 7 months ago by danakj
Modified:
6 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, enne (OOO), ojan
Visibility:
Public.

Description

Remove the WebWidget::paint override in fullscreen pepper. This method no longer used as we are always in composited mode. R=piman BUG=251960 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268014

Patch Set 1 #

Patch Set 2 : webwidget-pepper: #

Total comments: 1

Patch Set 3 : webwidget-pepper: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M content/renderer/render_widget_fullscreen_pepper.cc View 1 2 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
danakj
6 years, 7 months ago (2014-05-02 22:35:50 UTC) #1
danakj
I had to reverse this :) Right now nothing is defined, so that's the default ...
6 years, 7 months ago (2014-05-02 22:38:00 UTC) #2
piman
https://codereview.chromium.org/267863007/diff/20001/content/renderer/render_widget_fullscreen_pepper.cc File content/renderer/render_widget_fullscreen_pepper.cc (right): https://codereview.chromium.org/267863007/diff/20001/content/renderer/render_widget_fullscreen_pepper.cc#newcode177 content/renderer/render_widget_fullscreen_pepper.cc:177: #endif This isn't called anymore, actually, I'm pretty sure. ...
6 years, 7 months ago (2014-05-02 22:43:11 UTC) #3
danakj
Removing the method now.
6 years, 7 months ago (2014-05-02 22:55:56 UTC) #4
piman
lgtm
6 years, 7 months ago (2014-05-02 23:36:07 UTC) #5
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 7 months ago (2014-05-02 23:41:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/267863007/40001
6 years, 7 months ago (2014-05-02 23:42:11 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-03 02:35:23 UTC) #8
Message was sent while issue was closed.
Change committed as 268014

Powered by Google App Engine
This is Rietveld 408576698