Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 267863006: Add support for 4-item AppMenu row. (Closed)

Created:
6 years, 7 months ago by aurimas (slooooooooow)
Modified:
6 years, 7 months ago
Reviewers:
Ted C, gone
CC:
chromium-reviews
Visibility:
Public.

Description

Add support for 4-item AppMenu row. BUG=369680 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267995

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -2 lines) Patch
A + chrome/android/java/res/layout/four_button_menu_item.xml View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java View 5 chunks +36 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
aurimas (slooooooooow)
dfalcantara: PTAL
6 years, 7 months ago (2014-05-02 22:06:52 UTC) #1
gone
lgtm, for prototyping.
6 years, 7 months ago (2014-05-02 22:08:52 UTC) #2
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 7 months ago (2014-05-02 22:16:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/267863006/1
6 years, 7 months ago (2014-05-02 22:17:18 UTC) #4
aurimas (slooooooooow)
The CQ bit was unchecked by aurimas@chromium.org
6 years, 7 months ago (2014-05-02 22:17:54 UTC) #5
aurimas (slooooooooow)
+tedchoc: OWNERS LGTM?
6 years, 7 months ago (2014-05-02 22:18:22 UTC) #6
Ted C
lgtm
6 years, 7 months ago (2014-05-02 22:28:12 UTC) #7
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 7 months ago (2014-05-02 22:30:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/267863006/1
6 years, 7 months ago (2014-05-02 22:31:21 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-03 01:02:34 UTC) #10
Message was sent while issue was closed. 
Change committed as 267995

Powered by Google App Engine
This is Rietveld 408576698