Adds syncedNotificationsPrivate API IDL.

Adds syncedNotificationsPrivate API IDL.

API is not implemented, just setting up the bindings.

Try jobs were run but constantly getting merge failures with histograms.xml, so adding no try flag.

NOTRY=true
BUG=372556
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270156

[dewittj, 2014-05-02 21:28:38]

kalman: all
isherman: histograms
petewil: all

There is some interesting clang formatting in this patch; let me know if it bugs
any of you.  Thanks!

[not at google - send to devlin, 2014-05-02 21:37:37]

lgtm

https://codereview.chromium.org/267863005/diff/1/chrome/browser/extensions/ap...
File
chrome/browser/extensions/api/synced_notifications_private/synced_notifications_private_api.cc
(right):

https://codereview.chromium.org/267863005/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/synced_notifications_private/synced_notifications_private_api.cc:32:
// Get parameters
these "Get parameters" comments don't seem helpful

https://codereview.chromium.org/267863005/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/_api_features.json (right):

https://codereview.chromium.org/267863005/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/_api_features.json:683: "channel": "dev",
channel restriction should be on the permission not the API; though I see it
already is

https://codereview.chromium.org/267863005/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/_permission_features.json (right):

https://codereview.chromium.org/267863005/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/_permission_features.json:827: "channel": "dev",
restrict unimplemented APIs to trunk not dev

https://codereview.chromium.org/267863005/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/_permission_features.json:828: "extension_types":
["platform_app"]
you will need a whitelist for this eventually? could you artificially restrict
it to component extensions for now, then write your tests against that?

https://codereview.chromium.org/267863005/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/synced_notifications_private.idl (right):

https://codereview.chromium.org/267863005/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/synced_notifications_private.idl:7: [nodoc]
namespace syncedNotificationsPrivate {
no need for [nodoc] if you don't add an .html file.

https://codereview.chromium.org/267863005/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/synced_notifications_private.idl:32: // Datatype
that represents a single sync change to a notification or an app info.
For whole file: keep IDL line length to 80 chars or it looks weird in code
review

https://codereview.chromium.org/267863005/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/synced_notifications_private.idl:43: // Get all
data from sync representing the current state (for use at startup).
Gets all data...

https://codereview.chromium.org/267863005/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/synced_notifications_private.idl:48: // Sending a
changed (read state) notification back up to sync.  To keep the sync from
Sends a changed...

https://codereview.chromium.org/267863005/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/synced_notifications_private.idl:52: // Setting the
Locale and DPI scale factor and list of sending services, encoded as a binary
Sets the locale...

[Ilya Sherman, 2014-05-02 21:42:19]

histograms lgtm

[dewittj, 2014-05-03 00:07:48]

kalman: one question in comments + two tweaks to the API:
 * onSyncStartup now no longer sends data with the event.  App should call
getInitialData.
 * getInitialData includes a type in the arguments, it is the data type that is
requested.

https://codereview.chromium.org/267863005/diff/1/chrome/browser/extensions/ap...
File
chrome/browser/extensions/api/synced_notifications_private/synced_notifications_private_api.cc
(right):

https://codereview.chromium.org/267863005/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/synced_notifications_private/synced_notifications_private_api.cc:32:
// Get parameters
On 2014/05/02 21:37:38, kalman wrote:
> these "Get parameters" comments don't seem helpful

Done.

https://codereview.chromium.org/267863005/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/_api_features.json (right):

https://codereview.chromium.org/267863005/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/_api_features.json:683: "channel": "dev",
On 2014/05/02 21:37:38, kalman wrote:
> channel restriction should be on the permission not the API; though I see it
> already is

Done.

https://codereview.chromium.org/267863005/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/_permission_features.json (right):

https://codereview.chromium.org/267863005/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/_permission_features.json:827: "channel": "dev",
On 2014/05/02 21:37:38, kalman wrote:
> restrict unimplemented APIs to trunk not dev

Done.

https://codereview.chromium.org/267863005/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/_permission_features.json:828: "extension_types":
["platform_app"]
On 2014/05/02 21:37:38, kalman wrote:
> you will need a whitelist for this eventually? could you artificially restrict
> it to component extensions for now, then write your tests against that?

I would rather not have a whitelist so we can hack on it more freely but if you
think that's necessary I could create a web store id etc.  Is it ok to be open
on trunk temporarily?

https://codereview.chromium.org/267863005/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/synced_notifications_private.idl (right):

https://codereview.chromium.org/267863005/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/synced_notifications_private.idl:7: [nodoc]
namespace syncedNotificationsPrivate {
On 2014/05/02 21:37:38, kalman wrote:
> no need for [nodoc] if you don't add an .html file.

Done.

https://codereview.chromium.org/267863005/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/synced_notifications_private.idl:32: // Datatype
that represents a single sync change to a notification or an app info.
On 2014/05/02 21:37:38, kalman wrote:
> For whole file: keep IDL line length to 80 chars or it looks weird in code
> review

Done.

https://codereview.chromium.org/267863005/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/synced_notifications_private.idl:43: // Get all
data from sync representing the current state (for use at startup).
On 2014/05/02 21:37:38, kalman wrote:
> Gets all data...

Done.

https://codereview.chromium.org/267863005/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/synced_notifications_private.idl:48: // Sending a
changed (read state) notification back up to sync.  To keep the sync from
On 2014/05/02 21:37:38, kalman wrote:
> Sends a changed...

Done.

https://codereview.chromium.org/267863005/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/synced_notifications_private.idl:52: // Setting the
Locale and DPI scale factor and list of sending services, encoded as a binary
On 2014/05/02 21:37:38, kalman wrote:
> Sets the locale...

Done.

[not at google - send to devlin, 2014-05-03 00:13:58]

https://codereview.chromium.org/267863005/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/_permission_features.json (right):

https://codereview.chromium.org/267863005/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/_permission_features.json:828: "extension_types":
["platform_app"]
On 2014/05/03 00:07:49, dewittj wrote:
> On 2014/05/02 21:37:38, kalman wrote:
> > you will need a whitelist for this eventually? could you artificially
restrict
> > it to component extensions for now, then write your tests against that?
> 
> I would rather not have a whitelist so we can hack on it more freely but if
you
> think that's necessary I could create a web store id etc.  Is it ok to be open
> on trunk temporarily?

Open on trunk is fine. Damage there seems very limited. Add a comment though :)

[dewittj, 2014-05-09 19:52:08]

The CQ bit was checked by dewittj@chromium.org

[commit-bot: I haz the power, 2014-05-09 19:54:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dewittj@chromium.org/267863005/70001

[dewittj, 2014-05-09 21:52:42]

The CQ bit was unchecked by dewittj@chromium.org

[dewittj, 2014-05-09 23:15:18]

The CQ bit was checked by dewittj@chromium.org

[commit-bot: I haz the power, 2014-05-09 23:18:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dewittj@chromium.org/267863005/90001

[commit-bot: I haz the power, 2014-05-10 03:32:20]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-10 04:02:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-10 04:02:17]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[dewittj, 2014-05-10 05:49:22]

The CQ bit was checked by dewittj@chromium.org

[commit-bot: I haz the power, 2014-05-10 05:52:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dewittj@chromium.org/267863005/90001

[commit-bot: I haz the power, 2014-05-10 09:33:58]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-10 10:23:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-10 10:23:57]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[dewittj, 2014-05-12 16:43:04]

The CQ bit was checked by dewittj@chromium.org

[commit-bot: I haz the power, 2014-05-12 16:43:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dewittj@chromium.org/267863005/110001

[dewittj, 2014-05-12 19:02:37]

The CQ bit was checked by dewittj@chromium.org

[commit-bot: I haz the power, 2014-05-12 19:03:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dewittj@chromium.org/267863005/130001

[commit-bot: I haz the power, 2014-05-12 22:40:13]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-13 03:16:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-13 03:16:10]

Failed to apply patch for
extensions/browser/extension_function_histogram_value.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file extensions/browser/extension_function_histogram_value.h
  Hunk #1 FAILED at 821.
  1 out of 1 hunk FAILED -- saving rejects to file
extensions/browser/extension_function_histogram_value.h.rej

Patch:       extensions/browser/extension_function_histogram_value.h
Index: extensions/browser/extension_function_histogram_value.h
diff --git a/extensions/browser/extension_function_histogram_value.h
b/extensions/browser/extension_function_histogram_value.h
index
bef59ed5ab497b412d7ebc7e541be76deb9bc201..f16bb3742dc885b9203d37a4c1f8176ff848cb42
100644
--- a/extensions/browser/extension_function_histogram_value.h
+++ b/extensions/browser/extension_function_histogram_value.h
@@ -821,6 +821,9 @@ enum HistogramValue {
   FILESYSTEMPROVIDERINTERNAL_READDIRECTORYREQUESTEDSUCCESS,
   FILESYSTEMPROVIDERINTERNAL_READDIRECTORYREQUESTEDERROR,
   LEDGER_BATCHEXECUTE,
+  SYNCEDNOTIFICATIONSPRIVATE_GETINITIALDATA,
+  SYNCEDNOTIFICATIONSPRIVATE_UPDATENOTIFICATION,
+  SYNCEDNOTIFICATIONSPRIVATE_SETRENDERCONTEXT,
   // Last entry: Add new entries above and ensure to update
   // tools/metrics/histograms/histograms/histograms.xml.
   ENUM_BOUNDARY

[dewittj, 2014-05-13 18:50:26]

The CQ bit was checked by dewittj@chromium.org

[commit-bot: I haz the power, 2014-05-13 18:51:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dewittj@chromium.org/267863005/150001

[commit-bot: I haz the power, 2014-05-13 18:53:07]

Change committed as 270156