tests/DeferredCanvasTest.cpp - Issue 267863002: 4x allocation in PipeController is probably overkill.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/DeferredCanvasTest.cpp

Issue 267863002: 4x allocation in PipeController is probably overkill. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: update comment Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/DeferredCanvasTest.cpp

diff --git a/tests/DeferredCanvasTest.cpp b/tests/DeferredCanvasTest.cpp

index ffcbc23d5645f3aa512679c99b9e4ee888fcddcf..180594e388a3ed4784b92d6cef9e1eafb5eaa9ed 100644

--- a/tests/DeferredCanvasTest.cpp

+++ b/tests/DeferredCanvasTest.cpp

@@ -547,7 +547,6 @@ static void TestDeferredCanvasBitmapCaching(skiatest::Reporter* reporter) {

canvas->drawBitmap(sourceImages[0], 0, 0, NULL);

REPORTER_ASSERT(reporter, 2 == notificationCounter.fStorageAllocatedChangedCount);

canvas->drawBitmap(sourceImages[0], 0, 0, NULL);

- REPORTER_ASSERT(reporter, 2 == notificationCounter.fStorageAllocatedChangedCount);

Justin Novosad 2014/05/06 17:08:14 Could we keep this assert and put it inside "#ifde

mtklein 2014/05/06 17:36:43 You bet. Now testing both sides.

REPORTER_ASSERT(reporter, 1 == notificationCounter.fFlushedDrawCommandsCount);

REPORTER_ASSERT(reporter, canvas->storageAllocatedForRecording() < 2 * bitmapSize);

« no previous file with comments | « src/pipe/utils/SamplePipeControllers.cpp ('k') | no next file » | no next file with comments »