Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: src/pipe/utils/SamplePipeControllers.h

Issue 267863002: 4x allocation in PipeController is probably overkill. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: keep test Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/pipe/SkGPipeWrite.cpp ('k') | src/pipe/utils/SamplePipeControllers.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 Google Inc. 2 * Copyright 2012 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkBitmap.h" 8 #include "SkBitmap.h"
9 #include "SkChunkAlloc.h" 9 #include "SkChunkAlloc.h"
10 #include "SkGPipe.h" 10 #include "SkGPipe.h"
11 #include "SkPicture.h" 11 #include "SkPicture.h"
12 #include "SkTDArray.h" 12 #include "SkTDArray.h"
13 13
14 class SkCanvas; 14 class SkCanvas;
15 class SkMatrix; 15 class SkMatrix;
16 16
17 class PipeController : public SkGPipeController { 17 class PipeController : public SkGPipeController {
18 public: 18 public:
19 PipeController(SkCanvas* target, SkPicture::InstallPixelRefProc proc = NULL) ; 19 PipeController(SkCanvas* target, SkPicture::InstallPixelRefProc proc = NULL) ;
20 virtual ~PipeController(); 20
21 virtual void* requestBlock(size_t minRequest, size_t* actual) SK_OVERRIDE; 21 virtual void* requestBlock(size_t minRequest, size_t* actual) SK_OVERRIDE;
22 virtual void notifyWritten(size_t bytes) SK_OVERRIDE; 22 virtual void notifyWritten(size_t bytes) SK_OVERRIDE;
23 protected: 23 protected:
24 const void* getData() { return (const char*) fBlock + fBytesWritten; } 24 const void* getData() { return (const char*) fBlock.get() + fBytesWritten; }
25 SkGPipeReader fReader; 25 SkGPipeReader fReader;
26 private: 26 private:
27 void* fBlock; 27 SkAutoMalloc fBlock;
28 size_t fBlockSize; 28 size_t fBlockSize;
29 size_t fBytesWritten; 29 size_t fBytesWritten;
30 SkGPipeReader::Status fStatus; 30 SkGPipeReader::Status fStatus;
31 }; 31 };
32 32
33 //////////////////////////////////////////////////////////////////////////////// 33 ////////////////////////////////////////////////////////////////////////////////
34 34
35 class TiledPipeController : public PipeController { 35 class TiledPipeController : public PipeController {
36 public: 36 public:
37 TiledPipeController(const SkBitmap&, SkPicture::InstallPixelRefProc proc = N ULL, 37 TiledPipeController(const SkBitmap&, SkPicture::InstallPixelRefProc proc = N ULL,
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 void* fBlock; 78 void* fBlock;
79 // Number of bytes that were written to fBlock. 79 // Number of bytes that were written to fBlock.
80 size_t fBytes; 80 size_t fBytes;
81 }; 81 };
82 void* fBlock; 82 void* fBlock;
83 size_t fBytesWritten; 83 size_t fBytesWritten;
84 SkChunkAlloc fAllocator; 84 SkChunkAlloc fAllocator;
85 SkTDArray<PipeBlock> fBlockList; 85 SkTDArray<PipeBlock> fBlockList;
86 int fNumberOfReaders; 86 int fNumberOfReaders;
87 }; 87 };
OLDNEW
« no previous file with comments | « src/pipe/SkGPipeWrite.cpp ('k') | src/pipe/utils/SamplePipeControllers.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698