Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js

Issue 2678623002: DevTools: pass title when creating settings (Closed)
Patch Set: ac Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js b/third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js
index 692e451deba19f9bb1b871b091f71b63e7f45c91..951b5e0f9aef0de6d778ac3b3a28e7142422cc90 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js
@@ -161,8 +161,8 @@ Timeline.EventsTimelineTreeView.Filters = class extends Common.Object {
for (var durationMs of Timeline.EventsTimelineTreeView.Filters._durationFilterPresetsMs) {
durationFilterUI.addOption(durationFilterUI.createOption(
durationMs ? Common.UIString('\u2265 %d\u2009ms', durationMs) : Common.UIString('All'),
- durationMs ? Common.UIString('Hide records shorter than %d\u2009ms', durationMs)
- : Common.UIString('Show all records'),
+ durationMs ? Common.UIString('Hide records shorter than %d\u2009ms', durationMs) :
+ Common.UIString('Show all records'),
String(durationMs)));
}
toolbar.appendToolbarItem(durationFilterUI);
@@ -173,8 +173,8 @@ Timeline.EventsTimelineTreeView.Filters = class extends Common.Object {
var category = categories[categoryName];
if (!category.visible)
continue;
- var checkbox = new UI.ToolbarCheckbox(
- category.title, undefined, undefined, categoriesFilterChanged.bind(this, categoryName));
+ var checkbox =
+ new UI.ToolbarCheckbox(category.title, undefined, categoriesFilterChanged.bind(this, categoryName));
checkbox.setChecked(true);
checkbox.inputElement.style.backgroundColor = category.color;
categoryFiltersUI[category.name] = checkbox;

Powered by Google App Engine
This is Rietveld 408576698