third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js - Issue 2678623002: DevTools: pass title when creating settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

Issue 2678623002: DevTools: pass title when creating settings (Closed)

Patch Set: ac Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSelector.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js b/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

index bebb91a3e8ca832f058b4596b84d2a12cb18d0b7..af55aa88b121b837bbc5807555967cc5345dba60 100644

--- a/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

+++ b/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

@@ -18,14 +18,15 @@ Resources.ServiceWorkersView = class extends UI.VBox {

this._sections = new Map();

this._toolbar.appendToolbarItem(NetworkConditions.NetworkConditionsSelector.createOfflineToolbarCheckbox());

- var forceUpdate = new UI.ToolbarCheckbox(

- Common.UIString('Update on reload'), Common.UIString('Force update Service Worker on page reload'),

- Common.settings.createSetting('serviceWorkerUpdateOnReload', false));

+ var updateOnReloadSetting = Common.settings.createSetting('serviceWorkerUpdateOnReload', false);

+ updateOnReloadSetting.setTitle(Common.UIString('Update on reload'));

+ var forceUpdate = new UI.ToolbarSettingCheckbox(

+ updateOnReloadSetting, Common.UIString('Force update Service Worker on page reload'));

this._toolbar.appendToolbarItem(forceUpdate);

- var fallbackToNetwork = new UI.ToolbarCheckbox(

- Common.UIString('Bypass for network'),

- Common.UIString('Bypass Service Worker and load resources from the network'),

- Common.settings.createSetting('bypassServiceWorker', false));

+ var bypassServiceWorkerSetting = Common.settings.createSetting('bypassServiceWorker', false);

+ bypassServiceWorkerSetting.setTitle(Common.UIString('Bypass for network'));

+ var fallbackToNetwork = new UI.ToolbarSettingCheckbox(

+ bypassServiceWorkerSetting, Common.UIString('Bypass Service Worker and load resources from the network'));

this._toolbar.appendToolbarItem(fallbackToNetwork);

this._toolbar.appendSpacer();

this._showAllCheckbox = new UI.ToolbarCheckbox(