third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js - Issue 2678623002: DevTools: pass title when creating settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

Issue 2678623002: DevTools: pass title when creating settings (Closed)

Patch Set: ac Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/layer_viewer/Layers3DView.js ('k') | third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSelector.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

index 26747b30ec3c08b2b5f74b28dfc43631a0b75ac8..586ed14377dcebf7b6ffb3bf4618bc80220cb0d6 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

@@ -170,9 +170,9 @@ Network.NetworkPanel = class extends UI.Panel {

'change', this._onPreserveLogCheckboxChanged.bind(this), false);

this._panelToolbar.appendToolbarItem(this._preserveLogCheckbox);

- this._disableCacheCheckbox = new UI.ToolbarCheckbox(

- Common.UIString('Disable cache'), Common.UIString('Disable cache (while DevTools is open)'),

- Common.moduleSetting('cacheDisabled'));

+ this._disableCacheCheckbox = new UI.ToolbarSettingCheckbox(

+ Common.moduleSetting('cacheDisabled'), Common.UIString('Disable cache (while DevTools is open)'),

+ Common.UIString('Disable cache'));

this._panelToolbar.appendToolbarItem(this._disableCacheCheckbox);

this._panelToolbar.appendSeparator();