Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2678623002: DevTools: pass title when creating settings (Closed)
Patch Set: ac Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
index c39376afb17fa19833210c899a4afe3e55bc84c0..c8e5bb0fcf519bf759cbf20b9a46ef4d9804a431 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
@@ -80,12 +80,12 @@ Console.ConsoleView = class extends UI.VBox {
toolbar.appendSeparator();
toolbar.appendToolbarItem(this._showSettingsPaneButton);
- this._preserveLogCheckbox = new UI.ToolbarCheckbox(
- Common.UIString('Preserve log'), Common.UIString('Do not clear log on page reload / navigation'),
- Common.moduleSetting('preserveConsoleLog'));
- this._hideNetworkMessagesCheckbox = new UI.ToolbarCheckbox(
- Common.UIString('Hide network'), Common.UIString('Hide network messages'),
- this._filter._hideNetworkMessagesSetting);
+ this._preserveLogCheckbox = new UI.ToolbarSettingCheckbox(
+ Common.moduleSetting('preserveConsoleLog'), Common.UIString('Do not clear log on page reload / navigation'),
+ Common.UIString('Preserve log'));
+ this._hideNetworkMessagesCheckbox = new UI.ToolbarSettingCheckbox(
+ this._filter._hideNetworkMessagesSetting, this._filter._hideNetworkMessagesSetting.title(),
+ Common.UIString('Hide network'));
var settingsToolbar = new UI.Toolbar('', this._contentsElement);
settingsToolbar.appendToolbarItem(this._hideNetworkMessagesCheckbox);
@@ -1039,7 +1039,7 @@ Console.ConsoleViewFilter = class {
*/
constructor(filterChangedCallback) {
this._showTargetMessagesCheckbox =
- new UI.ToolbarCheckbox(Common.UIString('Selected context only'), undefined, undefined, filterChangedCallback);
+ new UI.ToolbarCheckbox(Common.UIString('Selected context only'), undefined, filterChangedCallback);
this._filterChanged = filterChangedCallback;
this._messageURLFiltersSetting = Common.settings.createSetting('messageURLFilters', {});

Powered by Google App Engine
This is Rietveld 408576698