DevTools: pass title when creating settings

third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js

Index: third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js b/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
index 121478bf95565792d96d54cff2dc32dceaa4c9c3..a44de80ad976b04a2a3ec90ec8accb7a1580547c 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
@@ -964,18 +964,15 @@ UI.ToolbarSettingComboBox = class extends UI.ToolbarComboBox {
 UI.ToolbarCheckbox = class extends UI.ToolbarItem {
   /**
    * @param {string} text
-   * @param {string=} title
-   * @param {!Common.Setting=} setting
+   * @param {string=} tooltip
    * @param {function()=} listener
    */
-  constructor(text, title, setting, listener) {
+  constructor(text, tooltip, listener) {
     super(UI.createCheckboxLabel(text));
     this.element.classList.add('checkbox');
     this.inputElement = this.element.checkboxElement;
-    if (title)
-      this.element.title = title;
-    if (setting)
-      UI.SettingsUI.bindCheckbox(this.inputElement, setting);
+    if (tooltip)
+      this.element.title = tooltip;
     if (listener)
       this.inputElement.addEventListener('click', listener, false);
   }
@@ -1003,3 +1000,15 @@ UI.ToolbarCheckbox = class extends UI.ToolbarItem {
     this.inputElement.disabled = !enabled;
   }
 };
+
+UI.ToolbarSettingCheckbox = class extends UI.ToolbarCheckbox {
+  /**
+   * @param {!Common.Setting} setting
+   * @param {string=} tooltip
+   * @param {function()=} listener
+   */
+  constructor(setting, tooltip, listener) {

[pfeldman, 2017/02/07 20:10:28]

Here you should allow optional title and no listener - one should listen to a
setting instead.

[luoe, 2017/02/13 06:27:20]

Done.

+    super(setting.title() || '', tooltip, listener);
+    UI.SettingsUI.bindCheckbox(this.inputElement, setting);
+  }
+};