third_party/WebKit/Source/devtools/front_end/layer_viewer/Layers3DView.js - Issue 2678623002: DevTools: pass title when creating settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/layer_viewer/Layers3DView.js

Issue 2678623002: DevTools: pass title when creating settings (Closed)

Patch Set: a Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/common/Settings.js ('K') | « third_party/WebKit/Source/devtools/front_end/elements/module.json ('k') | third_party/WebKit/Source/devtools/front_end/main/module.json » ('j') | third_party/WebKit/Source/devtools/front_end/main/module.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/layer_viewer/Layers3DView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/layer_viewer/Layers3DView.js b/third_party/WebKit/Source/devtools/front_end/layer_viewer/Layers3DView.js

index 52f1fe91877c8271ea7c8dd77101e04e5f0e91b7..27dcda017d0f1ecf38c920af2c160c831a3a2542 100644

--- a/third_party/WebKit/Source/devtools/front_end/layer_viewer/Layers3DView.js

+++ b/third_party/WebKit/Source/devtools/front_end/layer_viewer/Layers3DView.js

@@ -666,11 +666,9 @@ LayerViewer.Layers3DView = class extends UI.VBox {

* @return {!Common.Setting}

_createVisibilitySetting(caption, name, value, toolbar) {

- var checkbox = new UI.ToolbarCheckbox(Common.UIString(caption));

- toolbar.appendToolbarItem(checkbox);

- var setting = Common.settings.createSetting(name, value);

- UI.SettingsUI.bindCheckbox(checkbox.inputElement, setting);

+ var setting = Common.settings.createSetting(name, value, false, Common.UIString(caption));

setting.addChangeListener(this._update, this);

+ toolbar.appendToolbarItem(new UI.ToolbarSettingCheckbox(setting));

return setting;

}