third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js - Issue 2678623002: DevTools: pass title when creating settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js

Issue 2678623002: DevTools: pass title when creating settings (Closed)

Patch Set: a Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/common/Settings.js ('K') | « third_party/WebKit/Source/devtools/front_end/common/Settings.js ('k') | third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js » ('j') | third_party/WebKit/Source/devtools/front_end/main/module.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js b/third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js

index 030c044df7f16a140f64d9ccfe70f4449e5aa7b8..ee0050e9620d6fd520a26231efb1743d9cea1a4d 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js

+++ b/third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js

@@ -171,7 +171,7 @@ Components.NetworkConditionsSelector = class {

static createOfflineToolbarCheckbox() {

var checkbox = new UI.ToolbarCheckbox(

- Common.UIString('Offline'), Common.UIString('Force disconnected from network'), undefined, forceOffline);

+ Common.UIString('Offline'), Common.UIString('Force disconnected from network'), forceOffline);

SDK.multitargetNetworkManager.addEventListener(

SDK.MultitargetNetworkManager.Events.ConditionsChanged, networkConditionsChanged);

checkbox.setChecked(SDK.multitargetNetworkManager.networkConditions() === SDK.NetworkManager.OfflineConditions);