DevTools: pass title when creating settings

third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @typedef {{
  *     lighthouseVersion: !string,
  *     generatedTime: !string,
  *     initialUrl: !string,
  *     url: !string,
@@ skipping 17 matching lines @@
 Audits2.Audits2Panel = class extends UI.Panel {
   constructor() {
     super('audits2');
     this.setHideOnDetach();
     this.registerRequiredCSS('audits2/audits2Panel.css');
 
     this._protocolService = new Audits2.ProtocolService();
     this._protocolService.registerStatusCallback(msg => this._updateStatus(Common.UIString(msg)));
 
     this._pwaSetting = Common.settings.createSetting('audits2_pwa', true);
+    this._pwaSetting.setTitle(Common.UIString('Progressive web app audits'));
     this._perfSetting = Common.settings.createSetting('audits2_perf', true);
+    this._perfSetting.setTitle(Common.UIString('Performance metrics and diagnostics'));
     this._practicesSetting = Common.settings.createSetting('audits2_best_practices', true);
+    this._practicesSetting.setTitle(Common.UIString('Modern web development best practices'));
 
     var auditsViewElement = this.contentElement.createChild('div', 'hbox audits-view');
     this._resultsView = this.contentElement.createChild('div', 'vbox results-view');
     auditsViewElement.appendChild(createElementWithClass('div', 'audits2-logo'));
     auditsViewElement.appendChild(this._createLauncherUI());
   }
 
   _reset() {
     this.contentElement.classList.remove('show-results');
     this._resultsView.removeChildren();
   }
 
-  /**
-   * @param {string} name
-   * @param {!Common.Setting} setting
-   * @return {!UI.ToolbarItem}
-   */
-  _createSettingCheckbox(name, setting) {
-    const checkboxItem = new UI.ToolbarCheckbox(name, undefined, setting);
-    return checkboxItem;
-  }
-
   _createLauncherUI() {
     var uiElement = createElement('div');
     var headerElement = uiElement.createChild('header');
     headerElement.createChild('p').textContent = Common.UIString(
         'Audits will analyze the page against modern development best practices and collect useful performance metrics and diagnostics. Select audits to collect:');
     uiElement.appendChild(headerElement);
 
     var auditSelectorForm = uiElement.createChild('form', 'audits2-form');
 
-    var perfCheckbox =
-        this._createSettingCheckbox(Common.UIString('Performance metrics and diagnostics'), this._perfSetting);
-    var pwaCheckbox = this._createSettingCheckbox(Common.UIString('Progressive web app audits'), this._pwaSetting);
-    var practicesCheckbox =
-        this._createSettingCheckbox(Common.UIString('Modern web development best practices'), this._practicesSetting);
+    var perfCheckbox = new UI.ToolbarSettingCheckbox(this._perfSetting);
+    var pwaCheckbox = new UI.ToolbarSettingCheckbox(this._pwaSetting);
+    var practicesCheckbox = new UI.ToolbarSettingCheckbox(this._practicesSetting);
     [perfCheckbox, practicesCheckbox, pwaCheckbox].forEach(checkbox => auditSelectorForm.appendChild(checkbox.element));
 
     this._startButton = UI.createTextButton(
         Common.UIString('Audit this page'), this._startButtonClicked.bind(this), 'run-audit audit-btn');
     auditSelectorForm.appendChild(this._startButton);
 
     this._statusView = this._createStatusView();
     uiElement.appendChild(this._statusView);
     return uiElement;
   }
@@ skipping 191 matching lines @@
    * @param {!Object=} params
    * @return {!Promise<!Audits2.WorkerResult|undefined>}
    */
   _send(method, params) {
     if (!this._backendPromise)
       this._initWorker();
 
     return this._backendPromise.then(_ => this._backend.send(method, params));
   }
 };