DevTools: pass title when creating settings

third_party/WebKit/Source/devtools/front_end/common/Settings.js

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 39 matching lines @@
 
   /**
    * @param {!Runtime.Extension} extension
    */
   _registerModuleSetting(extension) {
     var descriptor = extension.descriptor();
     var settingName = descriptor['settingName'];
     var settingType = descriptor['settingType'];
     var defaultValue = descriptor['defaultValue'];
     var isLocal = !!descriptor['local'];
-    var setting = settingType === 'regex' ? this.createRegExpSetting(settingName, defaultValue, undefined, isLocal) :
-                                            this.createSetting(settingName, defaultValue, isLocal);
+    var isRegex = settingType === 'regex';

[pfeldman, 2017/02/13 20:24:54]

revert

[luoe, 2017/02/13 22:18:26]

Done.

+    var setting = isRegex ? this.createRegExpSetting(settingName, defaultValue, undefined, isLocal) :
+                            this.createSetting(settingName, defaultValue, isLocal);
+    if (descriptor['title'])
+      setting.setTitle(descriptor['title']);
     this._moduleSettings.set(settingName, setting);
   }
 
   /**
    * @param {string} settingName
    * @return {!Common.Setting}
    */
   moduleSetting(settingName) {
     var setting = this._moduleSettings.get(settingName);
     if (!setting)
@@ skipping 13 matching lines @@
   }
 
   /**
    * @param {string} key
    * @param {*} defaultValue
    * @param {boolean=} isLocal
    * @return {!Common.Setting}
    */
   createSetting(key, defaultValue, isLocal) {
     if (!this._registry.get(key)) {
-      this._registry.set(
-          key, new Common.Setting(
-                   this, key, defaultValue, this._eventSupport, isLocal ? this._localStorage : this._settingsStorage));
+      var setting = new Common.Setting(

[pfeldman, 2017/02/13 20:24:54]

revert

[luoe, 2017/02/13 22:18:26]

Done.

+          this, key, defaultValue, this._eventSupport, isLocal ? this._localStorage : this._settingsStorage);
+      this._registry.set(key, setting);
     }
     return /** @type {!Common.Setting} */ (this._registry.get(key));
   }
 
   /**
    * @param {string} key
    * @param {*} defaultValue
    * @return {!Common.Setting}
    */
   createLocalSetting(key, defaultValue) {
     return this.createSetting(key, defaultValue, true);
   }
 
   /**
    * @param {string} key
    * @param {string} defaultValue
    * @param {string=} regexFlags
    * @param {boolean=} isLocal
    * @return {!Common.RegExpSetting}
    */
   createRegExpSetting(key, defaultValue, regexFlags, isLocal) {
     if (!this._registry.get(key)) {
-      this._registry.set(
-          key, new Common.RegExpSetting(
-                   this, key, defaultValue, this._eventSupport, isLocal ? this._localStorage : this._settingsStorage,
-                   regexFlags));
+      var setting = new Common.RegExpSetting(

[pfeldman, 2017/02/13 20:24:54]

ditto

[luoe, 2017/02/13 22:18:26]

Done.

+          this, key, defaultValue, this._eventSupport, isLocal ? this._localStorage : this._settingsStorage,
+          regexFlags);
+      this._registry.set(key, setting);
     }
     return /** @type {!Common.RegExpSetting} */ (this._registry.get(key));
   }
 
   clearAll() {
     this._settingsStorage.removeAll();
     this._localStorage.removeAll();
     var versionSetting = Common.settings.createSetting(Common.VersionController._currentVersionName, 0);
     versionSetting.set(Common.VersionController.currentVersion);
   }
@@ skipping 90 matching lines @@
    * @param {V} defaultValue
    * @param {!Common.Object} eventSupport
    * @param {!Common.SettingsStorage} storage
    */
   constructor(settings, name, defaultValue, eventSupport, storage) {
     this._settings = settings;
     this._name = name;
     this._defaultValue = defaultValue;
     this._eventSupport = eventSupport;
     this._storage = storage;
+    /** @type {string} */
+    this._title = '';
   }
 
   /**
    * @param {function(!Common.Event)} listener
    * @param {!Object=} thisObject
    */
   addChangeListener(listener, thisObject) {
     this._eventSupport.addEventListener(this._name, listener, thisObject);
   }
 
   /**
    * @param {function(!Common.Event)} listener
    * @param {!Object=} thisObject
    */
   removeChangeListener(listener, thisObject) {
     this._eventSupport.removeEventListener(this._name, listener, thisObject);
   }
 
   get name() {
     return this._name;
   }
 
   /**
+   * @return {string}
+   */
+  title() {
+    return this._title;
+  }
+
+  /**
+   * @param {string} title
+   */
+  setTitle(title) {
+    this._title = title;
+  }
+
+  /**
    * @return {V}
    */
   get() {
     if (typeof this._value !== 'undefined')
       return this._value;
 
     this._value = this._defaultValue;
     if (this._storage.has(this._name)) {
       try {
         this._value = JSON.parse(this._storage.get(this._name));
@@ skipping 493 matching lines @@
   return Common.settings.moduleSetting(settingName);
 };
 
 /**
  * @param {string} settingName
  * @return {!Common.Setting}
  */
 Common.settingForTest = function(settingName) {
   return Common.settings.settingForTest(settingName);
 };