DevTools: pass title when creating settings

third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 946 matching lines @@
     this._muteSettingListener = false;
   }
 };
 
 /**
  * @unrestricted
  */
 UI.ToolbarCheckbox = class extends UI.ToolbarItem {
   /**
    * @param {string} text
-   * @param {string=} title
-   * @param {!Common.Setting=} setting
+   * @param {string=} tooltip
    * @param {function()=} listener
    */
-  constructor(text, title, setting, listener) {
+  constructor(text, tooltip, listener) {
     super(UI.createCheckboxLabel(text));
     this.element.classList.add('checkbox');
     this.inputElement = this.element.checkboxElement;
-    if (title)
-      this.element.title = title;
-    if (setting)
-      UI.SettingsUI.bindCheckbox(this.inputElement, setting);
+    if (tooltip)
+      this.element.title = tooltip;
     if (listener)
       this.inputElement.addEventListener('click', listener, false);
   }
 
   /**
    * @return {boolean}
    */
   checked() {
     return this.inputElement.checked;
   }
 
   /**
    * @param {boolean} value
    */
   setChecked(value) {
     this.inputElement.checked = value;
   }
 
   /**
    * @override
    * @param {boolean} enabled
    */
   _applyEnabledState(enabled) {
     super._applyEnabledState(enabled);
     this.inputElement.disabled = !enabled;
   }
 };
+
+UI.ToolbarSettingCheckbox = class extends UI.ToolbarCheckbox {
+  /**
+   * @param {!Common.Setting} setting
+   * @param {string=} tooltip
+   * @param {function()=} listener
+   */
+  constructor(setting, tooltip, listener) {

[pfeldman, 2017/02/07 20:10:28]

Here you should allow optional title and no listener - one should listen to a
setting instead.

[luoe, 2017/02/13 06:27:20]

Done.

+    super(setting.title() || '', tooltip, listener);
+    UI.SettingsUI.bindCheckbox(this.inputElement, setting);
+  }
+};