Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Issue 2678623002: DevTools: pass title when creating settings (Closed)
Patch Set: a Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 674 matching lines...) Expand 10 before | Expand all | Expand 10 after
685 debugToolbar.appendToolbarItem(UI.Toolbar.createActionButton(this._stepIntoA ction)); 685 debugToolbar.appendToolbarItem(UI.Toolbar.createActionButton(this._stepIntoA ction));
686 debugToolbar.appendToolbarItem(UI.Toolbar.createActionButton(this._stepOutAc tion)); 686 debugToolbar.appendToolbarItem(UI.Toolbar.createActionButton(this._stepOutAc tion));
687 debugToolbar.appendSeparator(); 687 debugToolbar.appendSeparator();
688 debugToolbar.appendToolbarItem(UI.Toolbar.createActionButton(this._toggleBre akpointsActiveAction)); 688 debugToolbar.appendToolbarItem(UI.Toolbar.createActionButton(this._toggleBre akpointsActiveAction));
689 689
690 this._pauseOnExceptionButton = new UI.ToolbarToggle('', 'largeicon-pause-on- exceptions'); 690 this._pauseOnExceptionButton = new UI.ToolbarToggle('', 'largeicon-pause-on- exceptions');
691 this._pauseOnExceptionButton.addEventListener(UI.ToolbarButton.Events.Click, this._togglePauseOnExceptions, this); 691 this._pauseOnExceptionButton.addEventListener(UI.ToolbarButton.Events.Click, this._togglePauseOnExceptions, this);
692 debugToolbar.appendToolbarItem(this._pauseOnExceptionButton); 692 debugToolbar.appendToolbarItem(this._pauseOnExceptionButton);
693 693
694 debugToolbar.appendSeparator(); 694 debugToolbar.appendSeparator();
695 debugToolbar.appendToolbarItem(new UI.ToolbarCheckbox( 695 debugToolbar.appendToolbarItem(new UI.ToolbarSettingCheckbox(
696 Common.UIString('Async'), Common.UIString('Capture async stack traces'), 696 Common.moduleSetting('enableAsyncStackTraces'), Common.UIString('Capture async stack traces')));
pfeldman 2017/02/07 20:10:28 For example, here you want a shortcut.
luoe 2017/02/13 06:27:20 Done.
697 Common.moduleSetting('enableAsyncStackTraces')));
698 697
699 return debugToolbar; 698 return debugToolbar;
700 } 699 }
701 700
702 _createDebugToolbarDrawer() { 701 _createDebugToolbarDrawer() {
703 var debugToolbarDrawer = createElementWithClass('div', 'scripts-debug-toolba r-drawer'); 702 var debugToolbarDrawer = createElementWithClass('div', 'scripts-debug-toolba r-drawer');
704 703
705 var label = Common.UIString('Pause On Caught Exceptions'); 704 var label = Common.UIString('Pause On Caught Exceptions');
706 var setting = Common.moduleSetting('pauseOnCaughtException'); 705 var setting = Common.moduleSetting('pauseOnCaughtException');
707 debugToolbarDrawer.appendChild(UI.SettingsUI.createSettingCheckbox(label, se tting, true)); 706 debugToolbarDrawer.appendChild(UI.SettingsUI.createSettingCheckbox(label, se tting, true));
(...skipping 604 matching lines...) Expand 10 before | Expand all | Expand 10 after
1312 */ 1311 */
1313 willHide() { 1312 willHide() {
1314 UI.inspectorView.setDrawerMinimized(false); 1313 UI.inspectorView.setDrawerMinimized(false);
1315 setImmediate(() => Sources.SourcesPanel.updateResizerAndSidebarButtons(Sourc es.SourcesPanel.instance())); 1314 setImmediate(() => Sources.SourcesPanel.updateResizerAndSidebarButtons(Sourc es.SourcesPanel.instance()));
1316 } 1315 }
1317 1316
1318 _showViewInWrapper() { 1317 _showViewInWrapper() {
1319 this._view.show(this.element); 1318 this._view.show(this.element);
1320 } 1319 }
1321 }; 1320 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698