Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2678623002: DevTools: pass title when creating settings (Closed)
Patch Set: a Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 toolbar.appendToolbarItem(this._executionContextComboBox); 73 toolbar.appendToolbarItem(this._executionContextComboBox);
74 toolbar.appendSeparator(); 74 toolbar.appendSeparator();
75 toolbar.appendToolbarItem(this._filter._textFilterUI); 75 toolbar.appendToolbarItem(this._filter._textFilterUI);
76 toolbar.appendToolbarItem(this._filter._levelComboBox); 76 toolbar.appendToolbarItem(this._filter._levelComboBox);
77 toolbar.appendToolbarItem(this._progressToolbarItem); 77 toolbar.appendToolbarItem(this._progressToolbarItem);
78 toolbar.appendSpacer(); 78 toolbar.appendSpacer();
79 toolbar.appendText(''); 79 toolbar.appendText('');
80 toolbar.appendSeparator(); 80 toolbar.appendSeparator();
81 toolbar.appendToolbarItem(this._showSettingsPaneButton); 81 toolbar.appendToolbarItem(this._showSettingsPaneButton);
82 82
83 this._preserveLogCheckbox = new UI.ToolbarCheckbox( 83 this._preserveLogCheckbox = new UI.ToolbarSettingCheckbox(
84 Common.UIString('Preserve log'), Common.UIString('Do not clear log on pa ge reload / navigation'), 84 Common.moduleSetting('preserveConsoleLog'), Common.UIString('Do not clea r log on page reload / navigation'));
85 Common.moduleSetting('preserveConsoleLog')); 85 this._hideNetworkMessagesCheckbox =
86 this._hideNetworkMessagesCheckbox = new UI.ToolbarCheckbox( 86 new UI.ToolbarSettingCheckbox(this._filter._hideNetworkMessagesSetting, Common.UIString('Hide network'));
87 Common.UIString('Hide network'), Common.UIString('Hide network messages' ),
88 this._filter._hideNetworkMessagesSetting);
89 87
90 var settingsToolbar = new UI.Toolbar('', this._contentsElement); 88 var settingsToolbar = new UI.Toolbar('', this._contentsElement);
91 settingsToolbar.appendToolbarItem(this._hideNetworkMessagesCheckbox); 89 settingsToolbar.appendToolbarItem(this._hideNetworkMessagesCheckbox);
92 settingsToolbar.appendToolbarItem(this._preserveLogCheckbox); 90 settingsToolbar.appendToolbarItem(this._preserveLogCheckbox);
93 settingsToolbar.appendToolbarItem(this._filter._showTargetMessagesCheckbox); 91 settingsToolbar.appendToolbarItem(this._filter._showTargetMessagesCheckbox);
94 if (!this._showSettingsPaneSetting.get()) 92 if (!this._showSettingsPaneSetting.get())
95 settingsToolbar.element.classList.add('hidden'); 93 settingsToolbar.element.classList.add('hidden');
96 this._showSettingsPaneSetting.addChangeListener( 94 this._showSettingsPaneSetting.addChangeListener(
97 () => settingsToolbar.element.classList.toggle('hidden', !this._showSett ingsPaneSetting.get())); 95 () => settingsToolbar.element.classList.toggle('hidden', !this._showSett ingsPaneSetting.get()));
98 96
(...skipping 934 matching lines...) Expand 10 before | Expand all | Expand 10 after
1033 1031
1034 /** 1032 /**
1035 * @unrestricted 1033 * @unrestricted
1036 */ 1034 */
1037 Console.ConsoleViewFilter = class { 1035 Console.ConsoleViewFilter = class {
1038 /** 1036 /**
1039 * @param {function()} filterChangedCallback 1037 * @param {function()} filterChangedCallback
1040 */ 1038 */
1041 constructor(filterChangedCallback) { 1039 constructor(filterChangedCallback) {
1042 this._showTargetMessagesCheckbox = 1040 this._showTargetMessagesCheckbox =
1043 new UI.ToolbarCheckbox(Common.UIString('Selected context only'), undefin ed, undefined, filterChangedCallback); 1041 new UI.ToolbarCheckbox(Common.UIString('Selected context only'), undefin ed, filterChangedCallback);
1044 this._filterChanged = filterChangedCallback; 1042 this._filterChanged = filterChangedCallback;
1045 1043
1046 this._messageURLFiltersSetting = Common.settings.createSetting('messageURLFi lters', {}); 1044 this._messageURLFiltersSetting = Common.settings.createSetting('messageURLFi lters', {});
1047 this._messageLevelFiltersSetting = 1045 this._messageLevelFiltersSetting =
1048 Common.settings.createSetting('messageLevelFilters2', SDK.ConsoleMessage .MessageLevel.Info); 1046 Common.settings.createSetting('messageLevelFilters2', SDK.ConsoleMessage .MessageLevel.Info);
1049 this._hideNetworkMessagesSetting = Common.moduleSetting('hideNetworkMessages '); 1047 this._hideNetworkMessagesSetting = Common.moduleSetting('hideNetworkMessages ');
1050 1048
1051 this._messageURLFiltersSetting.addChangeListener(this._filterChanged); 1049 this._messageURLFiltersSetting.addChangeListener(this._filterChanged);
1052 this._messageLevelFiltersSetting.addChangeListener(this._filterChanged); 1050 this._messageLevelFiltersSetting.addChangeListener(this._filterChanged);
1053 this._hideNetworkMessagesSetting.addChangeListener(this._filterChanged); 1051 this._hideNetworkMessagesSetting.addChangeListener(this._filterChanged);
(...skipping 263 matching lines...) Expand 10 before | Expand all | Expand 10 after
1317 return true; 1315 return true;
1318 } 1316 }
1319 return false; 1317 return false;
1320 } 1318 }
1321 }; 1319 };
1322 1320
1323 /** 1321 /**
1324 * @typedef {{messageIndex: number, matchIndex: number}} 1322 * @typedef {{messageIndex: number, matchIndex: number}}
1325 */ 1323 */
1326 Console.ConsoleView.RegexMatchRange; 1324 Console.ConsoleView.RegexMatchRange;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698