Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: ios/web/web_state/ui/crw_web_controller.mm

Issue 2678473003: Removed investigation CHECK from didCommitNavigation. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/web/web_state/ui/crw_wk_navigation_states.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/ui/crw_web_controller.mm
diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm
index 09ee39101878e80c598af64d7ff1af152796cd91..a982c722ff662d2a73436ecbb6412467ada9fee4 100644
--- a/ios/web/web_state/ui/crw_web_controller.mm
+++ b/ios/web/web_state/ui/crw_web_controller.mm
@@ -4943,16 +4943,6 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;
- (void)webView:(WKWebView*)webView
didCommitNavigation:(WKNavigation*)navigation {
- // This method will crash if |currentSessionEntry| is null. If this check is
- // hit it means that |didStartProvisionalNavigation| was called as expected
- // but it did not call |registerLoadRequest|. TODO(crbug.com/676721): remove
- // this CHECK once there is at least one crash on this line (which means that
- // |didStartProvisionalNavigation| did not call |registerLoadRequest| and it
- // should be fixed.
- CHECK([self currentSessionEntry] || !navigation ||
- [_navigationStates stateForNavigation:navigation] ==
- web::WKNavigationState::STARTED);
-
[_navigationStates setState:web::WKNavigationState::COMMITTED
forNavigation:navigation];
« no previous file with comments | « no previous file | ios/web/web_state/ui/crw_wk_navigation_states.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698