media: Require SecureContext for EME APIs

third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html

Index: third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html b/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html
index 528fb97751ad2b4493fa437a155eec301694af92..98b92200cb4e6b97f521eeb4202dae85ceb92cf8 100644
--- a/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html
+++ b/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html
@@ -16,7 +16,6 @@ if (window.location.origin != get_host_info().UNAUTHENTICATED_ORIGIN) {
     if (!window.internals)
         assert_unreached('window.internals is required for this test');
 
-
     // Tests for APIs that are deprecated, but still allowed, on
     // insecure origins
     async_test(function() {
@@ -32,11 +31,6 @@ if (window.location.origin != get_host_info().UNAUTHENTICATED_ORIGIN) {
         window.addEventListener('deviceorientation', this.step_func_done());
     }, 'device orientation');
 
-    promise_test(function(test) {
-        return navigator.requestMediaKeySystemAccess('org.w3.clearkey',
-            [{ videoCapabilities: [{contentType: 'video/webm; codecs="vp9"'}] }]);
-    }, 'requestMediaKeySystemAccess');
-
     // Tests for APIs that have been turned off on insecure origins
     async_test(function() {
         navigator.geolocation.getCurrentPosition(
@@ -87,6 +81,11 @@ if (window.location.origin != get_host_info().UNAUTHENTICATED_ORIGIN) {
 
         applicationCache.addEventListener('cached', cached, false);
     }, 'appcache');
+
+    test(function() {
+      assert_false(navigator.hasOwnProperty('requestMediaKeySystemAccess'),

[foolip, 2017/02/07 00:06:11]

navigator.hasOwnProperty('requestMediaKeySystemAccess') was false before this
change as well because the method is on the prototype.
assert_false('requestMediaKeySystemAccess' in navigator) or assert_equals(typeof
navigator.requestMediaKeySystemAccess, "undefined") would work.

I'd suggest omitting the assert description since there's just one in the test.
(If kept, it should ideally describe the actual value, i.e. the first argument,
the resulting error messages make more sense this way.)

[xhwang, 2017/02/07 00:23:56]

I am not super familiar with this code, but here's what I think how things work.

navigator is the same as window.navigator which returns a reference to the
Navigator object. So you don't need the "prototype" part.
https://developer.mozilla.org/en-US/docs/Web/API/Window/navigator

Navigator (note the uppercase N) is the interface, so you would need the
prototype part.

I tried without my change that both of the following return true:

navigator.hasOwnProperty('requestMediaKeySystemAccess')
Navigator.prototype.hasOwnProperty('requestMediaKeySystemAccess')

I actually had "'requestMediaKeySystemAccess' in navigator" first, but then felt
hasOwnProperty() would seem a better way to do it. 

But I really don't have any strong opinion. With the explanation above, do you
still recommend to use "'requestMediaKeySystemAccess' in navigator" in the test?
 
Will do.

[foolip, 2017/02/07 00:27:12]

That's odd, I've tested in Chrome Stable and Chrome Canary, and in both
navigator.hasOwnProperty('requestMediaKeySystemAccess') are false even though
navigator.requestMediaKeySystemAccess exists and is a method.

Navigator.prototype.hasOwnProperty('requestMediaKeySystemAccess') is true
though, which is precisely what I expected. Can you re-confirm that
navigator.hasOwnProperty('requestMediaKeySystemAccess') returns true on ToT
without these changes?

+          'navigator.requestMediaKeySystemAccess should not be available.');
+    }, 'requestMediaKeySystemAccess');
 }
 </script>
 </body>