Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2678393002: Revert of Reland: [Parse] ParseInfo owns the parsing Zone. (Closed)

Created:
3 years, 10 months ago by Michael Achenbach
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland: [Parse] ParseInfo owns the parsing Zone. (patchset #6 id:120001 of https://codereview.chromium.org/2632123006/ ) Reason for revert: Makes the tree red. Maybe outdated compile tryjobs? E.g.: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20builder/builds/22988 Original issue's description: > Reland: [Parse] ParseInfo owns the parsing Zone. > > Moves ownership of the parsing Zone to ParseInfo with a shared_ptr. This is > in preperation for enabling background compilation jobs for inner functions > share the AST in the outer-function's parse zone memory (read-only), with the > and zone being released when all compilation jobs have completed. > > BUG=v8:5203, v8:5215 > > Review-Url: https://codereview.chromium.org/2632123006 > Cr-Commit-Position: refs/heads/master@{#42993} > Committed: https://chromium.googlesource.com/v8/v8/+/14fb337200d5da09c77438ddd40bea935b1dc823 TBR=marja@chromium.org,mstarzinger@chromium.org,ahaas@chromium.org,verwaest@chromium.org,rmcilroy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5203, v8:5215

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -198 lines) Patch
M src/asmjs/asm-wasm-builder.cc View 2 chunks +14 lines, -14 lines 0 comments Download
M src/background-parsing-task.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/background-parsing-task.cc View 2 chunks +4 lines, -1 line 0 comments Download
M src/compiler.cc View 9 chunks +17 lines, -9 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-job.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-job.cc View 6 chunks +8 lines, -4 lines 0 comments Download
M src/compiler/js-inlining.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/compiler/pipeline.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M src/crankshaft/hydrogen.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/debug-scopes.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/parsing/parse-info.h View 4 chunks +5 lines, -13 lines 0 comments Download
M src/parsing/parse-info.cc View 3 chunks +5 lines, -13 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/asmjs/test-asm-typer.cc View 12 chunks +28 lines, -30 lines 0 comments Download
M test/cctest/compiler/function-tester.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-linkage.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-loop-assignment-analysis.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 131 chunks +133 lines, -70 lines 0 comments Download
M test/cctest/parsing/test-preparser.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M test/cctest/test-parsing.cc View 19 chunks +32 lines, -17 lines 0 comments Download
M test/fuzzer/parser.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc View 4 chunks +7 lines, -3 lines 0 comments Download
M test/unittests/compiler-dispatcher/optimizing-compile-dispatcher-unittest.cc View 3 chunks +4 lines, -1 line 0 comments Download
M tools/parser-shell.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Achenbach
Created Revert of Reland: [Parse] ParseInfo owns the parsing Zone.
3 years, 10 months ago (2017-02-07 13:03:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678393002/1
3 years, 10 months ago (2017-02-07 13:03:23 UTC) #3
Michael Achenbach
Jochen was faster...
3 years, 10 months ago (2017-02-07 13:04:01 UTC) #5
marja
Sounds like a bug if the CQ commits stuff because of some too old tryjobs!
3 years, 10 months ago (2017-02-07 13:40:25 UTC) #6
Michael Achenbach
On 2017/02/07 13:40:25, marja wrote: > Sounds like a bug if the CQ commits stuff ...
3 years, 10 months ago (2017-02-07 13:47:00 UTC) #7
marja
3 years, 10 months ago (2017-02-07 13:47:58 UTC) #8
Message was sent while issue was closed.
On 2017/02/07 13:47:00, Michael Achenbach wrote:
> On 2017/02/07 13:40:25, marja wrote:
> > Sounds like a bug if the CQ commits stuff because of some too old tryjobs!
> 
> No that's by design. Otherwise CQ would need to rerun all bots each time HEAD
> changes. The current validity of a tryjobs is somewhere between 12 and 24
hours.
> But even if we limit it to 1-2 hours (which we could) we might get CLs racing
> with each other... Currently we get a breakage of that sort once every two
> weeks...

Yep, I realized based on the comments in the CL that it's a real in-flight
conflict and thus not a bug.

Powered by Google App Engine
This is Rietveld 408576698