net/socket/websocket_transport_client_socket_pool.h - Issue 2678353003: Close idle H2 sockets when SpdySession is initialized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/websocket_transport_client_socket_pool.h

Issue 2678353003: Close idle H2 sockets when SpdySession is initialized. (Closed)

Patch Set: Address comments to hook directly to ClientSocketHandle Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/websocket_transport_client_socket_pool.h

diff --git a/net/socket/websocket_transport_client_socket_pool.h b/net/socket/websocket_transport_client_socket_pool.h

index a2c0235f9f0c9e5177bb84e8c19c72d13f4b4f10..5758e9d74e08bf3281b82e4122fb3807d11d88cf 100644

--- a/net/socket/websocket_transport_client_socket_pool.h

+++ b/net/socket/websocket_transport_client_socket_pool.h

@@ -173,6 +173,7 @@ class NET_EXPORT_PRIVATE WebSocketTransportClientSocketPool

int id) override;

void FlushWithError(int error) override;

void CloseIdleSockets() override;

+ void CloseIdleSocketsInGroup(const std::string& group_name) override;

int IdleSocketCount() const override;

int IdleSocketCountInGroup(const std::string& group_name) const override;

LoadState GetLoadState(const std::string& group_name,