chromeos: decode video into NV12 format instead of RGBA in vaapi decoder

media/gpu/vaapi_drm_picture.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/gpu/vaapi_drm_picture.h"
 
 #include "base/file_descriptor_posix.h"
+#include "gpu/ipc/common/gpu_memory_buffer_support.h"
 #include "media/gpu/va_surface.h"
 #include "media/gpu/vaapi_wrapper.h"
 #include "third_party/libva/va/drm/va_drm.h"
 #include "third_party/libva/va/va.h"
 #include "ui/gfx/gpu_memory_buffer.h"
 #include "ui/gfx/native_pixmap.h"
 #include "ui/gl/gl_bindings.h"
 #include "ui/gl/gl_image_native_pixmap.h"
 #include "ui/gl/scoped_binders.h"
 #include "ui/ozone/public/ozone_platform.h"
@@ skipping 25 matching lines @@
 }
 
 static unsigned BufferFormatToInternalFormat(gfx::BufferFormat format) {
   switch (format) {
     case gfx::BufferFormat::BGRA_8888:
       return GL_BGRA_EXT;
 
     case gfx::BufferFormat::YVU_420:
       return GL_RGB_YCRCB_420_CHROMIUM;
 
+    case gfx::BufferFormat::YUV_420_BIPLANAR:
+      return GL_RGB_YCBCR_420V_CHROMIUM;
+
     default:
       NOTREACHED();
       return GL_BGRA_EXT;
   }
 }
 
 bool VaapiDrmPicture::Initialize() {
   DCHECK(pixmap_);
 
   va_surface_ = vaapi_wrapper_->CreateVASurfaceForPixmap(pixmap_);
@@ skipping 34 matching lines @@
       return false;
     }
   }
 
   return true;
 }
 
 bool VaapiDrmPicture::Allocate(gfx::BufferFormat format) {
   ui::OzonePlatform* platform = ui::OzonePlatform::GetInstance();
   ui::SurfaceFactoryOzone* factory = platform->GetSurfaceFactoryOzone();
+  gfx::BufferUsage usage = gfx::BufferUsage::GPU_READ;
+  DCHECK(gpu::IsNativeGpuMemoryBufferConfigurationSupported(format, usage));
+  if (gpu::IsNativeGpuMemoryBufferConfigurationSupported(
+          format, gfx::BufferUsage::SCANOUT))
+    usage = gfx::BufferUsage::SCANOUT;
   pixmap_ = factory->CreateNativePixmap(gfx::kNullAcceleratedWidget, size_,
-                                        format, gfx::BufferUsage::SCANOUT);
+                                        format, usage);
   if (!pixmap_) {
     DVLOG(1) << "Failed allocating a pixmap";
     return false;
   }
 
   return Initialize();
 }
 
 bool VaapiDrmPicture::ImportGpuMemoryBufferHandle(
     gfx::BufferFormat format,
@@ skipping 11 matching lines @@
 
   return Initialize();
 }
 
 bool VaapiDrmPicture::DownloadFromSurface(
     const scoped_refptr<VASurface>& va_surface) {
   return vaapi_wrapper_->BlitSurface(va_surface, va_surface_);
 }
 
 bool VaapiDrmPicture::AllowOverlay() const {
-  return true;
+  // TODO(dshwang): make it true when cros kernel supports NV12 overlay.
+  // crbug.com/683347
+  return pixmap_->GetBufferUsage() == gfx::BufferUsage::SCANOUT;
 }
 
 }  // namespace media