Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: components/ntp_snippets/category.h

Issue 2678343004: [Suggestions category] Warn more about removing categories. (Closed)
Patch Set: Comments #2 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/ntp_snippets/category.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/category.h
diff --git a/components/ntp_snippets/category.h b/components/ntp_snippets/category.h
index 6e36a3aa47ec5c73672e28826bcc305ea8ee7e82..d3859fba5a25cdd7915c5e4b1aa577dd4f117c8d 100644
--- a/components/ntp_snippets/category.h
+++ b/components/ntp_snippets/category.h
@@ -33,7 +33,11 @@ enum class KnownCategories {
// Pages recently browsed to on other devices.
FOREIGN_TABS,
- // INSERT NEW LOCAL CATEGORIES HERE!
+
+ // ****************** INSERT NEW LOCAL CATEGORIES HERE! ******************
+ // Existing categories are persisted and they must never be removed. This may
+ // happen implicitly, e.g. when an older version without some local category
+ // is installed.
// Follows the last local category.
LOCAL_CATEGORIES_COUNT,
@@ -43,7 +47,8 @@ enum class KnownCategories {
// Articles for you.
ARTICLES,
- // INSERT NEW REMOTE CATEGORIES HERE!
+
+ // ****************** INSERT NEW REMOTE CATEGORIES HERE! ******************
// Tracks the last known remote category
LAST_KNOWN_REMOTE_CATEGORY = ARTICLES,
« no previous file with comments | « no previous file | components/ntp_snippets/category.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698