Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2678313003: Fix for issue 28638 - flakiness on dartkp-dart-precompiled caused by MallocHooks (Closed)

Created:
3 years, 10 months ago by siva
Modified:
3 years, 10 months ago
Reviewers:
bkonyi
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for issue 28638 - flakiness on dartkp-dart-precompiled caused by MallocHooks BUG=#28638 R=bkonyi@google.com Committed: https://github.com/dart-lang/sdk/commit/84e95a971f013ce4983b997e689c07096eee8c67

Patch Set 1 #

Patch Set 2 : Address self review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -33 lines) Patch
M runtime/vm/malloc_hooks.h View 1 chunk +6 lines, -6 lines 0 comments Download
M runtime/vm/malloc_hooks.cc View 1 10 chunks +42 lines, -21 lines 0 comments Download
M runtime/vm/malloc_hooks_unsupported.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M runtime/vm/service.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
3 years, 10 months ago (2017-02-08 02:46:37 UTC) #2
bkonyi
LGTM
3 years, 10 months ago (2017-02-08 17:52:47 UTC) #3
siva
3 years, 10 months ago (2017-02-08 21:45:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
84e95a971f013ce4983b997e689c07096eee8c67 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698