Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2678283003: Fix 'events_unittests' build (Closed)

Created:
3 years, 10 months ago by tonikitoo
Modified:
3 years, 10 months ago
Reviewers:
spang, kpschoedel
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, tdresser+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix 'events_unittests' build $ vim u/e/o/l/x/xkb_keyboard_layout_engine_unittest.cc : %s/VKEY_BACKSPACE/VKEY_BACK/gc : %s/VKEY_ENTER/VKEY_RETURN/gc TBR=kpschoedel@chromium.org,spang@chromium.org BUG=633238 Review-Url: https://codereview.chromium.org/2678283003 Cr-Commit-Position: refs/heads/master@{#448726} Committed: https://chromium.googlesource.com/chromium/src/+/f2da5092fa3e87ef4a0d8111f2818148238bd06c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
tonikitoo
TBR'ing as it fixes a trivial compilation issue, following kpschoedel@'s advice.
3 years, 10 months ago (2017-02-07 20:33:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678283003/1
3 years, 10 months ago (2017-02-07 20:34:17 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f2da5092fa3e87ef4a0d8111f2818148238bd06c
3 years, 10 months ago (2017-02-07 20:46:15 UTC) #10
kpschoedel
3 years, 10 months ago (2017-02-07 20:51:29 UTC) #11
Message was sent while issue was closed.
Retrospective LGTM.

Powered by Google App Engine
This is Rietveld 408576698