Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js

Issue 2678233002: DevTools: track more elements panel user actions (Closed)
Patch Set: CL comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
index 4ee0efa5336c873969ef9ea02bb9379dcb110afe..f9676ba54ac38613bf3777faeafde534be9440ea 100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
@@ -73,6 +73,7 @@ Elements.ElementsTreeOutline = class extends UI.TreeOutline {
this._selectedDOMNode = null;
this._visible = false;
+ this._reportedNodeSelectedUMA = false;
this._popoverHelper = new UI.PopoverHelper(this._element);
this._popoverHelper.initializeCallbacks(this._getPopoverAnchor.bind(this), this._showPopover.bind(this));
@@ -393,6 +394,9 @@ Elements.ElementsTreeOutline = class extends UI.TreeOutline {
* @param {boolean} focus
*/
_selectedNodeChanged(focus) {
+ if (this._reportedNodeSelectedUMA)
pfeldman 2017/02/10 23:00:46 !this._reportedNodeSelectedUMA
chenwilliam 2017/02/25 00:49:14 I want to report it on the second time and afterwa
+ Host.userMetrics.actionTaken(Host.UserMetrics.Action.ElementsTreeOutlineSelectNode);
+ this._reportedNodeSelectedUMA = true;
this.dispatchEventToListeners(
Elements.ElementsTreeOutline.Events.SelectedNodeChanged, {node: this._selectedDOMNode, focus: focus});
}

Powered by Google App Engine
This is Rietveld 408576698