third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js - Issue 2678233002: DevTools: track more elements panel user actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

Issue 2678233002: DevTools: track more elements panel user actions (Closed)

Patch Set: cl feedback Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/user-metrics-expected.txt ('k') | third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

index b370c306e56d354bb79ee383c18a20447d08ffa6..5e8fb07b064f7ebad89b3bd2ba1b36243c79b448 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

@@ -323,8 +323,10 @@ Elements.ElementsTreeElement = class extends UI.TreeElement {

onselect(selectedByUser) {

this.treeOutline.suppressRevealAndSelect = true;

this.treeOutline.selectDOMNode(this._node, selectedByUser);

- if (selectedByUser)

+ if (selectedByUser) {

this._node.highlight();

+ Host.userMetrics.actionTaken(Host.UserMetrics.Action.ChangeInspectedNodeInElementsPanel);

chenwilliam 2017/02/28 22:31:17 This only gets triggered when you select from the

+ }

this._createSelection();

this.treeOutline.suppressRevealAndSelect = false;

return true;