DevTools: track more elements panel user actions

third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com>
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 56 matching lines @@
     this.element = shadowContainer;
 
     this._includeRootDOMNode = !omitRootDOMNode;
     this._selectEnabled = selectEnabled;
     /** @type {?SDK.DOMNode} */
     this._rootDOMNode = null;
     /** @type {?SDK.DOMNode} */
     this._selectedDOMNode = null;
 
     this._visible = false;
+    this._shouldReportSelectedNodeChangedUMA = false;
 
     this._popoverHelper = new UI.PopoverHelper(this._element);
     this._popoverHelper.initializeCallbacks(this._getPopoverAnchor.bind(this), this._showPopover.bind(this));
     this._popoverHelper.setTimeout(0, 100);
 
     /** @type {!Map<!SDK.DOMNode, !Elements.ElementsTreeOutline.UpdateRecord>} */
     this._updateRecords = new Map();
     /** @type {!Set<!Elements.ElementsTreeElement>} */
     this._treeElementsBeingUpdated = new Set();
 
@@ skipping 300 matching lines @@
     }
 
     if (selectedNode)
       this._revealAndSelectNode(selectedNode, true);
   }
 
   /**
    * @param {boolean} focus
    */
   _selectedNodeChanged(focus) {
+    // Don't want to track first time selecting node because user may
+    // just be trying to open DevTools with "Inspect"
+    if (this._shouldReportSelectedNodeChangedUMA)
+      Host.userMetrics.actionTaken(Host.UserMetrics.Action.ChangeInspectedNodeInElementsPanel);
+    this._shouldReportSelectedNodeChangedUMA = true;
     this.dispatchEventToListeners(
         Elements.ElementsTreeOutline.Events.SelectedNodeChanged, {node: this._selectedDOMNode, focus: focus});
   }
 
   /**
    * @param {!Array.<!SDK.DOMNode>} nodes
    */
   _fireElementsTreeUpdated(nodes) {
     this.dispatchEventToListeners(Elements.ElementsTreeOutline.Events.ElementsTreeUpdated, nodes);
   }
@@ skipping 1267 matching lines @@
   }
 
   /**
    * @override
    * @param {boolean=} selectedByUser
    * @return {boolean}
    */
   onselect(selectedByUser) {
     if (!selectedByUser)
       return true;
     this._nodeShortcut.deferredNode.highlight();

[pfeldman, 2017/02/25 01:34:36]

This is a good place for manual selection tracking.

[chenwilliam, 2017/02/28 22:31:17]

I tried putting it here - but AFAICT it never gets triggered (both in manual
testing and our test suite). It seems that ElementsTreeElement onselect gets
triggered and not the Outline.

     this._nodeShortcut.deferredNode.resolve(resolved.bind(this));
     /**
      * @param {?SDK.DOMNode} node
      * @this {Elements.ElementsTreeOutline.ShortcutTreeElement}
      */
     function resolved(node) {
       if (node) {
         this.treeOutline._selectedDOMNode = node;
         this.treeOutline._selectedNodeChanged();
       }
     }
     return true;
   }
 };