Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js

Issue 2678233002: DevTools: track more elements panel user actions (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com> 3 * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com>
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 575 matching lines...) Expand 10 before | Expand all | Expand 10 after
586 */ 586 */
587 function showPopover(contents) { 587 function showPopover(contents) {
588 if (!contents) 588 if (!contents)
589 return; 589 return;
590 popover.setCanShrink(false); 590 popover.setCanShrink(false);
591 popover.showForAnchor(contents, link); 591 popover.showForAnchor(contents, link);
592 } 592 }
593 } 593 }
594 594
595 _onmousedown(event) { 595 _onmousedown(event) {
596 Host.userMetrics.actionTaken(Host.UserMetrics.Action.ElementsTreeOutlineClic k);
pfeldman 2017/02/07 19:15:27 That's going to be comparable to the style edit.
596 var element = this._treeElementFromEvent(event); 597 var element = this._treeElementFromEvent(event);
597 598
598 if (!element || element.isEventWithinDisclosureTriangle(event)) 599 if (!element || element.isEventWithinDisclosureTriangle(event))
599 return; 600 return;
600 601
601 element.select(); 602 element.select();
602 } 603 }
603 604
604 /** 605 /**
605 * @param {?UI.TreeElement} treeElement 606 * @param {?UI.TreeElement} treeElement
(...skipping 1082 matching lines...) Expand 10 before | Expand all | Expand 10 after
1688 */ 1689 */
1689 function resolved(node) { 1690 function resolved(node) {
1690 if (node) { 1691 if (node) {
1691 this.treeOutline._selectedDOMNode = node; 1692 this.treeOutline._selectedDOMNode = node;
1692 this.treeOutline._selectedNodeChanged(); 1693 this.treeOutline._selectedNodeChanged();
1693 } 1694 }
1694 } 1695 }
1695 return true; 1696 return true;
1696 } 1697 }
1697 }; 1698 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698