Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2678193002: Not task based analysis. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Not task based analysis. Work in progress. Constants are not evaluated. Operations, like URI resolution, type resolution, etc are not optimized. I'd like to land some initial state and then start iterating. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/236321245d77e639720d83f39f991de40028989e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+546 lines, -29 lines) Patch
A pkg/analyzer/lib/src/dart/analysis/analysis_impl.dart View 1 chunk +484 lines, -0 lines 1 comment Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 6 chunks +56 lines, -26 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/library_context.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 10 months ago (2017-02-06 21:43:32 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/2678193002/diff/1/pkg/analyzer/lib/src/dart/analysis/analysis_impl.dart File pkg/analyzer/lib/src/dart/analysis/analysis_impl.dart (right): https://codereview.chromium.org/2678193002/diff/1/pkg/analyzer/lib/src/dart/analysis/analysis_impl.dart#newcode86 pkg/analyzer/lib/src/dart/analysis/analysis_impl.dart:86: units.forEach((file, unit) { Can we merge this loop ...
3 years, 10 months ago (2017-02-06 22:44:36 UTC) #2
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-06 23:42:31 UTC) #3
scheglov
3 years, 10 months ago (2017-02-07 00:12:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
236321245d77e639720d83f39f991de40028989e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698