Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2451)

Unified Diff: chrome/browser/media/android/router/media_router_android.cc

Issue 2678123003: Revert of Convert MediaRouter mojom apis to intake url::Origin objects instead of strings (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/android/router/media_router_android.cc
diff --git a/chrome/browser/media/android/router/media_router_android.cc b/chrome/browser/media/android/router/media_router_android.cc
index 62e132b8ccc9d1bf6106cdc9a72882ac1646af62..9fa7aa64f3a124c44ee96637a4077b5033f4ddf9 100644
--- a/chrome/browser/media/android/router/media_router_android.cc
+++ b/chrome/browser/media/android/router/media_router_android.cc
@@ -75,12 +75,20 @@
void MediaRouterAndroid::CreateRoute(
const MediaSource::Id& source_id,
const MediaSink::Id& sink_id,
- const url::Origin& origin,
+ const GURL& origin,
content::WebContents* web_contents,
const std::vector<MediaRouteResponseCallback>& callbacks,
base::TimeDelta timeout,
bool incognito) {
// TODO(avayvod): Implement timeouts (crbug.com/583036).
+ if (!origin.is_valid()) {
+ std::unique_ptr<RouteRequestResult> result = RouteRequestResult::FromError(
+ "Invalid origin", RouteRequestResult::INVALID_ORIGIN);
+ for (const MediaRouteResponseCallback& callback : callbacks)
+ callback.Run(*result);
+ return;
+ }
+
std::string presentation_id = MediaRouterBase::CreatePresentationId();
int tab_id = -1;
@@ -103,10 +111,8 @@
base::android::ConvertUTF8ToJavaString(env, sink_id);
ScopedJavaLocalRef<jstring> jpresentation_id =
base::android::ConvertUTF8ToJavaString(env, presentation_id);
- // TODO(crbug.com/685358): Unique origins should not be considered
- // same-origin.
ScopedJavaLocalRef<jstring> jorigin =
- base::android::ConvertUTF8ToJavaString(env, origin.GetURL().spec());
+ base::android::ConvertUTF8ToJavaString(env, origin.spec());
Java_ChromeMediaRouter_createRoute(env, java_media_router_, jsource_id,
jsink_id, jpresentation_id, jorigin,
@@ -116,7 +122,7 @@
void MediaRouterAndroid::ConnectRouteByRouteId(
const MediaSource::Id& source,
const MediaRoute::Id& route_id,
- const url::Origin& origin,
+ const GURL& origin,
content::WebContents* web_contents,
const std::vector<MediaRouteResponseCallback>& callbacks,
base::TimeDelta timeout,
@@ -127,12 +133,20 @@
void MediaRouterAndroid::JoinRoute(
const MediaSource::Id& source_id,
const std::string& presentation_id,
- const url::Origin& origin,
+ const GURL& origin,
content::WebContents* web_contents,
const std::vector<MediaRouteResponseCallback>& callbacks,
base::TimeDelta timeout,
bool incognito) {
// TODO(avayvod): Implement timeouts (crbug.com/583036).
+ if (!origin.is_valid()) {
+ std::unique_ptr<RouteRequestResult> result = RouteRequestResult::FromError(
+ "Invalid origin", RouteRequestResult::INVALID_ORIGIN);
+ for (const MediaRouteResponseCallback& callback : callbacks)
+ callback.Run(*result);
+ return;
+ }
+
int tab_id = -1;
TabAndroid* tab = web_contents
? TabAndroid::FromWebContents(web_contents) : nullptr;
@@ -140,7 +154,7 @@
tab_id = tab->GetAndroidId();
DVLOG(2) << "JoinRoute: " << source_id << ", " << presentation_id << ", "
- << origin.GetURL().spec() << ", " << tab_id;
+ << origin.spec() << ", " << tab_id;
int request_id = route_requests_.Add(base::MakeUnique<MediaRouteRequest>(
MediaSource(source_id), presentation_id, callbacks));
@@ -151,7 +165,7 @@
ScopedJavaLocalRef<jstring> jpresentation_id =
base::android::ConvertUTF8ToJavaString(env, presentation_id);
ScopedJavaLocalRef<jstring> jorigin =
- base::android::ConvertUTF8ToJavaString(env, origin.GetURL().spec());
+ base::android::ConvertUTF8ToJavaString(env, origin.spec());
Java_ChromeMediaRouter_joinRoute(env, java_media_router_, jsource_id,
jpresentation_id, jorigin, tab_id,
@@ -334,7 +348,7 @@
if (it != sinks_observers_.end()) {
// TODO(imcheng): Pass origins to OnSinksUpdated (crbug.com/594858).
for (auto& observer : *it->second)
- observer.OnSinksUpdated(sinks_converted, std::vector<url::Origin>());
+ observer.OnSinksUpdated(sinks_converted, std::vector<GURL>());
}
}

Powered by Google App Engine
This is Rietveld 408576698