chrome/browser/media/router/create_presentation_connection_request_unittest.cc - Issue 2678123003: Revert of Convert MediaRouter mojom apis to intake url::Origin objects instead of strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/create_presentation_connection_request_unittest.cc

Issue 2678123003: Revert of Convert MediaRouter mojom apis to intake url::Origin objects instead of strings (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/create_presentation_connection_request.cc ('k') | chrome/browser/media/router/media_router.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/create_presentation_connection_request_unittest.cc

diff --git a/chrome/browser/media/router/create_presentation_connection_request_unittest.cc b/chrome/browser/media/router/create_presentation_connection_request_unittest.cc

index 6c373b9fb3b43c96dfee422472297bccaf2676fa..8e71ecb44e563d18f3fe85abf74ed53c6091efe3 100644

--- a/chrome/browser/media/router/create_presentation_connection_request_unittest.cc

+++ b/chrome/browser/media/router/create_presentation_connection_request_unittest.cc

@@ -68,14 +68,14 @@

content::PresentationError error(content::PRESENTATION_ERROR_UNKNOWN,

"Unknown error.");

CreatePresentationConnectionRequest request(

- render_frame_host_id_, presentation_urls_, url::Origin(GURL(kFrameUrl)),

+ render_frame_host_id_, presentation_urls_, GURL(kFrameUrl),

base::Bind(&CreatePresentationConnectionRequestTest::FailOnSuccess,

base::Unretained(this)),

base::Bind(&CreatePresentationConnectionRequestTest::OnError,

base::Unretained(this), error));

- PresentationRequest presentation_request(

- render_frame_host_id_, presentation_urls_, url::Origin(GURL(kFrameUrl)));

+ PresentationRequest presentation_request(render_frame_host_id_,

+ presentation_urls_, GURL(kFrameUrl));

EXPECT_TRUE(request.presentation_request().Equals(presentation_request));

// Since we didn't explicitly call Invoke*, the error callback will be

// invoked when |request| is destroyed.

@@ -85,7 +85,7 @@

content::PresentationSessionInfo session_info(presentation_url_,

kPresentationId);

CreatePresentationConnectionRequest request(

- render_frame_host_id_, {presentation_url_}, url::Origin(GURL(kFrameUrl)),

+ render_frame_host_id_, {presentation_url_}, GURL(kFrameUrl),

base::Bind(&CreatePresentationConnectionRequestTest::OnSuccess,

base::Unretained(this), session_info),

base::Bind(&CreatePresentationConnectionRequestTest::FailOnError,

@@ -101,7 +101,7 @@

content::PRESENTATION_ERROR_SESSION_REQUEST_CANCELLED,

"This is an error message");

CreatePresentationConnectionRequest request(

- render_frame_host_id_, presentation_urls_, url::Origin(GURL(kFrameUrl)),

+ render_frame_host_id_, presentation_urls_, GURL(kFrameUrl),

base::Bind(&CreatePresentationConnectionRequestTest::FailOnSuccess,

base::Unretained(this)),

base::Bind(&CreatePresentationConnectionRequestTest::OnError,