Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: chrome/browser/media/router/presentation_service_delegate_impl.cc

Issue 2678123003: Revert of Convert MediaRouter mojom apis to intake url::Origin objects instead of strings (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/media/router/presentation_service_delegate_impl.h" 5 #include "chrome/browser/media/router/presentation_service_delegate_impl.h"
6 6
7 #include <string> 7 #include <string>
8 #include <unordered_map> 8 #include <unordered_map>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 53
54 // Returns the unique identifier for the supplied RenderFrameHost. 54 // Returns the unique identifier for the supplied RenderFrameHost.
55 RenderFrameHostId GetRenderFrameHostId(RenderFrameHost* render_frame_host) { 55 RenderFrameHostId GetRenderFrameHostId(RenderFrameHost* render_frame_host) {
56 int render_process_id = render_frame_host->GetProcess()->GetID(); 56 int render_process_id = render_frame_host->GetProcess()->GetID();
57 int render_frame_id = render_frame_host->GetRoutingID(); 57 int render_frame_id = render_frame_host->GetRoutingID();
58 return RenderFrameHostId(render_process_id, render_frame_id); 58 return RenderFrameHostId(render_process_id, render_frame_id);
59 } 59 }
60 60
61 // Gets the last committed URL for the render frame specified by 61 // Gets the last committed URL for the render frame specified by
62 // |render_frame_host_id|. 62 // |render_frame_host_id|.
63 url::Origin GetLastCommittedURLForFrame( 63 GURL GetLastCommittedURLForFrame(RenderFrameHostId render_frame_host_id) {
64 RenderFrameHostId render_frame_host_id) {
65 RenderFrameHost* render_frame_host = RenderFrameHost::FromID( 64 RenderFrameHost* render_frame_host = RenderFrameHost::FromID(
66 render_frame_host_id.first, render_frame_host_id.second); 65 render_frame_host_id.first, render_frame_host_id.second);
67 DCHECK(render_frame_host); 66 if (!render_frame_host)
68 return render_frame_host->GetLastCommittedOrigin(); 67 return GURL();
68
69 // TODO(crbug.com/632623): Use url::Origin in place of GURL for origins
70 return render_frame_host->GetLastCommittedOrigin().GetURL();
69 } 71 }
70 72
71 // Observes messages originating from the MediaSink connected to a MediaRoute 73 // Observes messages originating from the MediaSink connected to a MediaRoute
72 // that represents a presentation. Converts the messages into 74 // that represents a presentation. Converts the messages into
73 // content::PresentationSessionMessages and dispatches them via the provided 75 // content::PresentationSessionMessages and dispatches them via the provided
74 // PresentationSessionMessageCallback. 76 // PresentationSessionMessageCallback.
75 class PresentationSessionMessagesObserver : public RouteMessageObserver { 77 class PresentationSessionMessagesObserver : public RouteMessageObserver {
76 public: 78 public:
77 // |message_cb|: The callback to invoke whenever messages are received. 79 // |message_cb|: The callback to invoke whenever messages are received.
78 // |route_id|: ID of MediaRoute to listen for messages. 80 // |route_id|: ID of MediaRoute to listen for messages.
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 216
215 bool PresentationFrame::SetScreenAvailabilityListener( 217 bool PresentationFrame::SetScreenAvailabilityListener(
216 content::PresentationScreenAvailabilityListener* listener) { 218 content::PresentationScreenAvailabilityListener* listener) {
217 MediaSource source(GetMediaSourceFromListener(listener)); 219 MediaSource source(GetMediaSourceFromListener(listener));
218 auto& sinks_observer = url_to_sinks_observer_[source.id()]; 220 auto& sinks_observer = url_to_sinks_observer_[source.id()];
219 if (sinks_observer && sinks_observer->listener() == listener) 221 if (sinks_observer && sinks_observer->listener() == listener)
220 return false; 222 return false;
221 223
222 sinks_observer.reset(new PresentationMediaSinksObserver( 224 sinks_observer.reset(new PresentationMediaSinksObserver(
223 router_, listener, source, 225 router_, listener, source,
224 GetLastCommittedURLForFrame(render_frame_host_id_))); 226 GetLastCommittedURLForFrame(render_frame_host_id_).GetOrigin()));
225 227
226 if (!sinks_observer->Init()) { 228 if (!sinks_observer->Init()) {
227 url_to_sinks_observer_.erase(source.id()); 229 url_to_sinks_observer_.erase(source.id());
228 listener->OnScreenAvailabilityNotSupported(); 230 listener->OnScreenAvailabilityNotSupported();
229 return false; 231 return false;
230 } 232 }
231 233
232 return true; 234 return true;
233 } 235 }
234 236
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
524 const RenderFrameHostId& render_frame_host_id, 526 const RenderFrameHostId& render_frame_host_id,
525 const std::vector<GURL>& default_presentation_urls, 527 const std::vector<GURL>& default_presentation_urls,
526 const content::PresentationSessionStartedCallback& callback) { 528 const content::PresentationSessionStartedCallback& callback) {
527 if (!IsMainFrame(render_frame_host_id)) 529 if (!IsMainFrame(render_frame_host_id))
528 return; 530 return;
529 531
530 if (default_presentation_urls.empty()) { 532 if (default_presentation_urls.empty()) {
531 ClearDefaultPresentationRequest(); 533 ClearDefaultPresentationRequest();
532 } else { 534 } else {
533 DCHECK(!callback.is_null()); 535 DCHECK(!callback.is_null());
534 const auto& frame_origin = 536 GURL frame_url(GetLastCommittedURLForFrame(render_frame_host_id));
535 GetLastCommittedURLForFrame(render_frame_host_id);
536 PresentationRequest request(render_frame_host_id, default_presentation_urls, 537 PresentationRequest request(render_frame_host_id, default_presentation_urls,
537 frame_origin); 538 frame_url);
538 default_presentation_started_callback_ = callback; 539 default_presentation_started_callback_ = callback;
539 SetDefaultPresentationRequest(request); 540 SetDefaultPresentationRequest(request);
540 } 541 }
541 } 542 }
542 543
543 void PresentationFrameManager::AddDefaultPresentationRequestObserver( 544 void PresentationFrameManager::AddDefaultPresentationRequestObserver(
544 PresentationServiceDelegateImpl::DefaultPresentationRequestObserver* 545 PresentationServiceDelegateImpl::DefaultPresentationRequestObserver*
545 observer) { 546 observer) {
546 default_presentation_request_observers_.AddObserver(observer); 547 default_presentation_request_observers_.AddObserver(observer);
547 } 548 }
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
780 const content::PresentationSessionStartedCallback& success_cb, 781 const content::PresentationSessionStartedCallback& success_cb,
781 const content::PresentationSessionErrorCallback& error_cb) { 782 const content::PresentationSessionErrorCallback& error_cb) {
782 DVLOG(2) << "PresentationServiceDelegateImpl::JoinSession"; 783 DVLOG(2) << "PresentationServiceDelegateImpl::JoinSession";
783 if (presentation_urls.empty()) { 784 if (presentation_urls.empty()) {
784 error_cb.Run(content::PresentationError( 785 error_cb.Run(content::PresentationError(
785 content::PRESENTATION_ERROR_NO_PRESENTATION_FOUND, 786 content::PRESENTATION_ERROR_NO_PRESENTATION_FOUND,
786 "Invalid presentation arguments.")); 787 "Invalid presentation arguments."));
787 return; 788 return;
788 } 789 }
789 790
790 const url::Origin& origin = GetLastCommittedURLForFrame( 791 const url::Origin& origin = url::Origin(GetLastCommittedURLForFrame(
791 RenderFrameHostId(render_process_id, render_frame_id)); 792 RenderFrameHostId(render_process_id, render_frame_id)));
792 793
793 #if !defined(OS_ANDROID) 794 #if !defined(OS_ANDROID)
794 if (IsAutoJoinPresentationId(presentation_id) && 795 if (IsAutoJoinPresentationId(presentation_id) &&
795 ShouldCancelAutoJoinForOrigin(origin)) { 796 ShouldCancelAutoJoinForOrigin(origin)) {
796 error_cb.Run(content::PresentationError( 797 error_cb.Run(content::PresentationError(
797 content::PRESENTATION_ERROR_SESSION_REQUEST_CANCELLED, 798 content::PRESENTATION_ERROR_SESSION_REQUEST_CANCELLED,
798 "Auto-join request cancelled by user preferences.")); 799 "Auto-join request cancelled by user preferences."));
799 return; 800 return;
800 } 801 }
801 #endif // !defined(OS_ANDROID) 802 #endif // !defined(OS_ANDROID)
802 803
803 // TODO(crbug.com/627655): Handle multiple URLs. 804 // TODO(crbug.com/627655): Handle multiple URLs.
804 const GURL& presentation_url = presentation_urls[0]; 805 const GURL& presentation_url = presentation_urls[0];
805 bool incognito = web_contents_->GetBrowserContext()->IsOffTheRecord(); 806 bool incognito = web_contents_->GetBrowserContext()->IsOffTheRecord();
806 std::vector<MediaRouteResponseCallback> route_response_callbacks; 807 std::vector<MediaRouteResponseCallback> route_response_callbacks;
807 route_response_callbacks.push_back( 808 route_response_callbacks.push_back(
808 base::Bind(&PresentationServiceDelegateImpl::OnJoinRouteResponse, 809 base::Bind(&PresentationServiceDelegateImpl::OnJoinRouteResponse,
809 weak_factory_.GetWeakPtr(), render_process_id, render_frame_id, 810 weak_factory_.GetWeakPtr(), render_process_id, render_frame_id,
810 presentation_url, presentation_id, success_cb, error_cb)); 811 presentation_url, presentation_id, success_cb, error_cb));
811 router_->JoinRoute(MediaSourceForPresentationUrl(presentation_url).id(), 812 router_->JoinRoute(MediaSourceForPresentationUrl(presentation_url).id(),
812 presentation_id, origin, web_contents_, 813 presentation_id, origin.GetURL(), web_contents_,
813 route_response_callbacks, base::TimeDelta(), incognito); 814 route_response_callbacks, base::TimeDelta(), incognito);
814 } 815 }
815 816
816 void PresentationServiceDelegateImpl::CloseConnection( 817 void PresentationServiceDelegateImpl::CloseConnection(
817 int render_process_id, 818 int render_process_id,
818 int render_frame_id, 819 int render_frame_id,
819 const std::string& presentation_id) { 820 const std::string& presentation_id) {
820 const RenderFrameHostId rfh_id(render_process_id, render_frame_id); 821 const RenderFrameHostId rfh_id(render_process_id, render_frame_id);
821 const MediaRoute::Id& route_id = 822 const MediaRoute::Id& route_id =
822 frame_manager_->GetRouteId(rfh_id, presentation_id); 823 frame_manager_->GetRouteId(rfh_id, presentation_id);
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
968 const base::ListValue* origins = 969 const base::ListValue* origins =
969 Profile::FromBrowserContext(web_contents_->GetBrowserContext()) 970 Profile::FromBrowserContext(web_contents_->GetBrowserContext())
970 ->GetPrefs() 971 ->GetPrefs()
971 ->GetList(prefs::kMediaRouterTabMirroringSources); 972 ->GetList(prefs::kMediaRouterTabMirroringSources);
972 return origins && 973 return origins &&
973 origins->Find(base::StringValue(origin.Serialize())) != origins->end(); 974 origins->Find(base::StringValue(origin.Serialize())) != origins->end();
974 } 975 }
975 #endif // !defined(OS_ANDROID) 976 #endif // !defined(OS_ANDROID)
976 977
977 } // namespace media_router 978 } // namespace media_router
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698