chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc - Issue 2678083005: Remove extension-to-component migration mechanism

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc

Issue 2678083005: Remove extension-to-component migration mechanism (Closed)

Patch Set: Address Mike's comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/toolbar/media_router_action_controller.cc ('K') | « chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc ('k') | chrome/common/pref_names.h » ('j') | chrome/common/pref_names.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc

diff --git a/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc b/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc

index 63820ad88bbec19c08c9fd740655ba79f418650e..ee9c699c024dfaad645060d1b1b618e4ff227159 100644

--- a/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc

+++ b/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc

@@ -101,10 +101,8 @@ class MediaRouterUIBrowserTest : public InProcessBrowserTest {

}

void SetAlwaysShowActionPref(bool always_show) {

- return ToolbarActionsModel::Get(browser()->profile())

- ->component_migration_helper()

- ->SetComponentActionPref(

- ComponentToolbarActionsFactory::kMediaRouterActionId, always_show);

+ return MediaRouterActionController::SetAlwaysShowActionPref(

Devlin 2017/02/08 15:20:01 no return from void function

takumif 2017/02/08 17:38:15 Oops, fixed.

+ browser()->profile(), always_show);

}

AppMenuButton* GetAppMenuButton() {