Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1504)

Unified Diff: chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc

Issue 2678083005: Remove extension-to-component migration mechanism (Closed)
Patch Set: Address Derek's comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc
diff --git a/chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc b/chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc
index 17730a732ef2aa3ec2d787bc6bc5723a9e737142..9fac8d6cb24ed95c309f143e8a34a6b9030671aa 100644
--- a/chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc
+++ b/chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc
@@ -12,6 +12,7 @@
#include "chrome/browser/signin/signin_manager_factory.h"
#include "chrome/browser/ui/toolbar/component_toolbar_actions_factory.h"
#include "chrome/browser/ui/toolbar/media_router_action.h"
+#include "chrome/browser/ui/toolbar/media_router_action_controller.h"
#include "chrome/browser/ui/toolbar/media_router_contextual_menu.h"
#include "chrome/test/base/browser_with_test_window_test.h"
@@ -139,28 +140,22 @@ TEST_F(MediaRouterContextualMenuUnitTest, ToggleCloudServicesItem) {
TEST_F(MediaRouterContextualMenuUnitTest, ToggleAlwaysShowIconItem) {
MediaRouterContextualMenu menu(browser());
- extensions::ComponentMigrationHelper* const component_migration_helper =
- toolbar_actions_model()->component_migration_helper();
// Whether the option is checked should reflect the pref.
- component_migration_helper->SetComponentActionPref(
- ComponentToolbarActionsFactory::kMediaRouterActionId, true);
+ MediaRouterActionController::SetAlwaysShowActionPref(profile(), true);
EXPECT_TRUE(
menu.IsCommandIdChecked(IDC_MEDIA_ROUTER_ALWAYS_SHOW_TOOLBAR_ACTION));
- component_migration_helper->SetComponentActionPref(
- ComponentToolbarActionsFactory::kMediaRouterActionId, false);
+ MediaRouterActionController::SetAlwaysShowActionPref(profile(), false);
EXPECT_FALSE(
menu.IsCommandIdChecked(IDC_MEDIA_ROUTER_ALWAYS_SHOW_TOOLBAR_ACTION));
// Executing the option should toggle the pref.
menu.ExecuteCommand(IDC_MEDIA_ROUTER_ALWAYS_SHOW_TOOLBAR_ACTION, 0);
- EXPECT_TRUE(component_migration_helper->GetComponentActionPref(
- ComponentToolbarActionsFactory::kMediaRouterActionId));
+ EXPECT_TRUE(MediaRouterActionController::GetAlwaysShowActionPref(profile()));
menu.ExecuteCommand(IDC_MEDIA_ROUTER_ALWAYS_SHOW_TOOLBAR_ACTION, 0);
- EXPECT_FALSE(component_migration_helper->GetComponentActionPref(
- ComponentToolbarActionsFactory::kMediaRouterActionId));
+ EXPECT_FALSE(MediaRouterActionController::GetAlwaysShowActionPref(profile()));
}
TEST_F(MediaRouterContextualMenuUnitTest, ActionShownByPolicy) {

Powered by Google App Engine
This is Rietveld 408576698