Remove extension-to-component migration mechanism

chrome/browser/ui/toolbar/media_router_action_controller_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 #include <string>
 
 #include "chrome/browser/media/router/mock_media_router.h"
+#include "chrome/browser/ui/toolbar/component_action_delegate.h"
 #include "chrome/browser/ui/toolbar/component_toolbar_actions_factory.h"
 #include "chrome/browser/ui/toolbar/media_router_action_controller.h"
 #include "chrome/browser/ui/webui/media_router/media_router_web_ui_test.h"
 #include "chrome/common/pref_names.h"
 #include "testing/gmock/include/gmock/gmock.h"
 
-using extensions::ComponentMigrationHelper;
-
-class FakeComponentActionDelegate
-    : public ComponentMigrationHelper::ComponentActionDelegate {
+class FakeComponentActionDelegate : public ComponentActionDelegate {
  public:
   FakeComponentActionDelegate() {}
   ~FakeComponentActionDelegate() {}
 
   void AddComponentAction(const std::string& action_id) override {
     EXPECT_EQ(action_id, ComponentToolbarActionsFactory::kMediaRouterActionId);
     EXPECT_FALSE(HasComponentAction(
         ComponentToolbarActionsFactory::kMediaRouterActionId));
     has_media_router_action_ = true;
   }
@@ skipping 23 matching lines @@
             media_router::IssueInfo::Severity::NOTIFICATION)),
         source1_("fakeSource1"),
         source2_("fakeSource2") {}
 
   ~MediaRouterActionControllerUnitTest() override {}
 
   // MediaRouterWebUITest:
   void SetUp() override {
     MediaRouterWebUITest::SetUp();
 
     router_.reset(new media_router::MockMediaRouter());

[msw, 2017/02/08 02:14:02]

optional nit: base::MakeUnique here and twice more below

[takumif, 2017/02/08 03:35:41]

Done.

     component_action_delegate_.reset(new FakeComponentActionDelegate());
-    component_migration_helper_.reset(new ComponentMigrationHelper(
-        profile(), component_action_delegate_.get()));
     controller_.reset(new MediaRouterActionController(
-        profile(), router_.get(), component_action_delegate_.get(),
-        component_migration_helper_.get()));
+        profile(), router_.get(), component_action_delegate_.get()));
 
     SetAlwaysShowActionPref(false);
 
     local_display_route_list_.push_back(
         media_router::MediaRoute("routeId1", source1_, "sinkId1", "description",
                                  true, std::string(), true));
     non_local_display_route_list_.push_back(
         media_router::MediaRoute("routeId2", source1_, "sinkId2", "description",
                                  false, std::string(), true));
     non_local_display_route_list_.push_back(
         media_router::MediaRoute("routeId3", source2_, "sinkId3", "description",
                                  true, std::string(), false));
   }
 
   void TearDown() override {
     controller_.reset();
-    component_migration_helper_.reset();
     component_action_delegate_.reset();
     router_.reset();
     MediaRouterWebUITest::TearDown();
   }
 
   bool ActionExists() {
     return component_action_delegate_->HasComponentAction(
         ComponentToolbarActionsFactory::kMediaRouterActionId);
   }
 
   void SetAlwaysShowActionPref(bool always_show) {
-    component_migration_helper_->SetComponentActionPref(
-        ComponentToolbarActionsFactory::kMediaRouterActionId, always_show);
+    MediaRouterActionController::SetAlwaysShowActionPref(profile(),
+                                                         always_show);
   }
 
   MediaRouterActionController* controller() { return controller_.get(); }
 
   const media_router::Issue& issue() { return issue_; }
   const std::vector<media_router::MediaRoute>& local_display_route_list()
       const {
     return local_display_route_list_;
   }
   const std::vector<media_router::MediaRoute>& non_local_display_route_list()
       const {
     return non_local_display_route_list_;
   }
   const std::vector<media_router::MediaRoute::Id>& empty_route_id_list() const {
     return empty_route_id_list_;
   }
 
  private:
   std::unique_ptr<MediaRouterActionController> controller_;
   std::unique_ptr<media_router::MockMediaRouter> router_;
   std::unique_ptr<FakeComponentActionDelegate> component_action_delegate_;
-  std::unique_ptr<ComponentMigrationHelper> component_migration_helper_;
 
   const media_router::Issue issue_;
 
   // Fake Sources, used for the Routes.
   const media_router::MediaSource source1_;
   const media_router::MediaSource source2_;
 
   std::vector<media_router::MediaRoute> local_display_route_list_;
   std::vector<media_router::MediaRoute> non_local_display_route_list_;
   std::vector<media_router::MediaRoute::Id> empty_route_id_list_;
@@ skipping 87 matching lines @@
 
   SetAlwaysShowActionPref(true);
   controller()->OnRoutesUpdated(non_local_display_route_list(),
                                 empty_route_id_list());
   // Removing the local route should not hide the icon.
   EXPECT_TRUE(ActionExists());
 
   SetAlwaysShowActionPref(false);
   EXPECT_FALSE(ActionExists());
 }