Remove extension-to-component migration mechanism

chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/toolbar/toolbar_actions_model.h"
 
 #include <stddef.h>
 
 #include <memory>
 
@@ skipping 109 matching lines @@
     : public extensions::ExtensionServiceTestBase {
  public:
   ToolbarActionsModelUnitTest() {}
   ~ToolbarActionsModelUnitTest() override {}
 
  protected:
   // Initialize the ExtensionService, ToolbarActionsModel, and
   // ExtensionSystem.
   void Init();
 
-  enum class MigrationStatus {
-    // The feature is enabled without any extension to migrate.
-    FEATURE_ENABLED_NO_EXTENSION,
-    // The feature is enabled and the user has installed an extension.
-    FEATURE_ENABLED_EXTENSION_INSTALLED,
-    // Feature is enabled with extension and a pref of false.
-    FEATURE_ENABLED_WITH_PREF_FALSE,
-    // Feature is enabled with extension and a pref of true.
-    FEATURE_ENABLED_WITH_PREF_TRUE,
-    // The feature is now disabled after previously being enabled, and the user
-    // has a pref reflecting a previous migration.
-    FEATURE_DISABLED_WITH_PREF_TRUE,
-  };
-
-  // Initialize the ExtensionService, ToolbarActionsModel, and ExtensionSystem,
-  // and an action extension to migrate to a component.  |migration_status|
-  // is used to configure the user's initial migration status.
-  void InitForMigrationTest(MigrationStatus migration_status);
-
   void TearDown() override;
 
   // Adds or removes the given |extension| and verify success.
   testing::AssertionResult AddExtension(
       const scoped_refptr<const extensions::Extension>& extension)
       WARN_UNUSED_RESULT;
   testing::AssertionResult RemoveExtension(
       const scoped_refptr<const extensions::Extension>& extension)
       WARN_UNUSED_RESULT;
 
   // Adds three extensions, all with browser actions.
   testing::AssertionResult AddBrowserActionExtensions() WARN_UNUSED_RESULT;
 
   // Adds three extensions, one each for browser action, page action, and no
   // action, and are added in that order.
   testing::AssertionResult AddActionExtensions() WARN_UNUSED_RESULT;
 
-  // Creates an extension that is to be migrated to a component action.
-  void CreateMigratedActionExtension();
-
   // Returns the action's id at the given index in the toolbar model, or empty
   // if one does not exist.
   // If |model| is specified, it is used. Otherwise, this defaults to
   // |toolbar_model_|.
   const std::string GetActionIdAtIndex(size_t index,
                                        const ToolbarActionsModel* model) const;
   const std::string GetActionIdAtIndex(size_t index) const;
 
   // Returns true if the |toobar_model_| has an action with the given |id|.
   bool ModelHasActionForId(const std::string& id) const;
@@ skipping 13 matching lines @@
   }
   const extensions::Extension* browser_action_b() const {
     return browser_action_b_.get();
   }
   const extensions::Extension* browser_action_c() const {
     return browser_action_c_.get();
   }
   const extensions::Extension* browser_action() const {
     return browser_action_extension_.get();
   }
-  const extensions::Extension* browser_action_migrated() const {
-    return browser_action_migrated_.get();
-  }
   const extensions::Extension* page_action() const {
     return page_action_extension_.get();
   }
   const extensions::Extension* no_action() const {
     return no_action_extension_.get();
   }
 
   // The mock component action will be referred to as "MCA" below.
   const char* component_action_id() {
     return MockComponentToolbarActionsFactory::kActionIdForTesting;
   }
 
  private:
   // Verifies that all extensions in |extensions| are added successfully.
   testing::AssertionResult AddAndVerifyExtensions(
       const extensions::ExtensionList& extensions);
 
   // The toolbar model associated with the testing profile.
   ToolbarActionsModel* toolbar_model_;
 
   // The test observer to track events. Must come after toolbar_model_ so that
   // it is destroyed and removes itself as an observer first.
   std::unique_ptr<ToolbarActionsModelTestObserver> model_observer_;
 
   // Sample extensions with only browser actions.
   scoped_refptr<const extensions::Extension> browser_action_a_;
   scoped_refptr<const extensions::Extension> browser_action_b_;
   scoped_refptr<const extensions::Extension> browser_action_c_;
-  scoped_refptr<const extensions::Extension> browser_action_migrated_;
 
   // Sample extensions with different kinds of actions.
   scoped_refptr<const extensions::Extension> browser_action_extension_;
   scoped_refptr<const extensions::Extension> page_action_extension_;
   scoped_refptr<const extensions::Extension> no_action_extension_;
 
   std::unique_ptr<MockComponentToolbarActionsFactory> mock_actions_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ToolbarActionsModelUnitTest);
 };
 
 void ToolbarActionsModelUnitTest::Init() {
   InitializeEmptyExtensionService();
   toolbar_model_ =
       extensions::extension_action_test_util::CreateToolbarModelForProfile(
           profile());
   model_observer_.reset(new ToolbarActionsModelTestObserver(toolbar_model_));
 }
 
-void ToolbarActionsModelUnitTest::InitForMigrationTest(
-    MigrationStatus migration_status) {
-  InitializeEmptyExtensionService();
-  SetMockActionsFactory(new MockComponentToolbarActionsFactory(nullptr));
-  CreateMigratedActionExtension();
-
-  {
-    DictionaryPrefUpdate update(profile()->GetPrefs(),
-                                ::prefs::kToolbarMigratedComponentActionStatus);
-    switch (migration_status) {
-      case MigrationStatus::FEATURE_ENABLED_EXTENSION_INSTALLED:
-        mock_actions_factory_->set_migrated_feature_enabled(true);
-        ASSERT_TRUE(AddExtension(browser_action_migrated()));
-        break;
-      case MigrationStatus::FEATURE_ENABLED_NO_EXTENSION:
-        mock_actions_factory_->set_migrated_feature_enabled(true);
-        break;
-      case MigrationStatus::FEATURE_ENABLED_WITH_PREF_TRUE:
-        mock_actions_factory_->set_migrated_feature_enabled(true);
-        ASSERT_TRUE(AddExtension(browser_action_migrated()));
-        update->SetBoolean(component_action_id(), true);
-        break;
-      case MigrationStatus::FEATURE_ENABLED_WITH_PREF_FALSE:
-        mock_actions_factory_->set_migrated_feature_enabled(true);
-        ASSERT_TRUE(AddExtension(browser_action_migrated()));
-        update->SetBoolean(component_action_id(), false);
-        break;
-      case MigrationStatus::FEATURE_DISABLED_WITH_PREF_TRUE:
-        mock_actions_factory_->set_migrated_feature_enabled(false);
-        ASSERT_TRUE(AddExtension(browser_action_migrated()));
-        update->SetBoolean(component_action_id(), true);
-        break;
-    }
-  }
-
-  toolbar_model_ =
-      extensions::extension_action_test_util::CreateToolbarModelForProfile(
-          profile());
-  model_observer_.reset(new ToolbarActionsModelTestObserver(toolbar_model_));
-}
-
 void ToolbarActionsModelUnitTest::TearDown() {
   model_observer_.reset();
   extensions::ExtensionServiceTestBase::TearDown();
 }
 
 testing::AssertionResult ToolbarActionsModelUnitTest::AddExtension(
     const scoped_refptr<const extensions::Extension>& extension) {
   if (registry()->enabled_extensions().GetByID(extension->id())) {
     return testing::AssertionFailure() << "Extension " << extension->name()
                                        << " already installed!";
@@ skipping 57 matching lines @@
           extensions::extension_action_test_util::BROWSER_ACTION);
 
   extensions::ExtensionList extensions;
   extensions.push_back(browser_action_a_);
   extensions.push_back(browser_action_b_);
   extensions.push_back(browser_action_c_);
 
   return AddAndVerifyExtensions(extensions);
 }
 
-void ToolbarActionsModelUnitTest::CreateMigratedActionExtension() {
-  browser_action_migrated_ =
-      extensions::extension_action_test_util::CreateActionExtension(
-          "browser_actionMigrated",
-          extensions::extension_action_test_util::BROWSER_ACTION);
-  mock_actions_factory_->set_migrated_extension_id(
-      browser_action_migrated_->id());
-}
-
 const std::string ToolbarActionsModelUnitTest::GetActionIdAtIndex(
     size_t index,
     const ToolbarActionsModel* model) const {
   return index < model->toolbar_items().size()
              ? model->toolbar_items()[index].id
              : std::string();
 }
 
 const std::string ToolbarActionsModelUnitTest::GetActionIdAtIndex(
     size_t index) const {
@@ skipping 1138 matching lines @@
   InitializeEmptyExtensionService();
   ToolbarActionsModel* toolbar_model = extensions::extension_action_test_util::
       CreateToolbarModelForProfileWithoutWaitingForReady(profile());
   ASSERT_FALSE(toolbar_model->actions_initialized());
 
   // AddComponentAction() should be a no-op if actions_initialized() is false.
   toolbar_model->AddComponentAction(component_action_id());
   EXPECT_EQ(0u, toolbar_model->toolbar_items().size());
   EXPECT_FALSE(toolbar_model->HasComponentAction(component_action_id()));
 }
-
-TEST_F(ToolbarActionsModelUnitTest,
-       NoMigrationToComponentActionWithoutExtension) {
-  extensions::FeatureSwitch::ScopedOverride enable_redesign(
-      extensions::FeatureSwitch::extension_action_redesign(), true);
-  InitForMigrationTest(MigrationStatus::FEATURE_ENABLED_NO_EXTENSION);
-
-  EXPECT_EQ(0u, num_toolbar_items());
-}
-
-TEST_F(ToolbarActionsModelUnitTest, MigrationFromExtensionToComponentAction) {
-  extensions::FeatureSwitch::ScopedOverride enable_redesign(
-      extensions::FeatureSwitch::extension_action_redesign(), true);
-  InitForMigrationTest(MigrationStatus::FEATURE_ENABLED_EXTENSION_INSTALLED);
-
-  // Initialization disables the extension and adds the migrated component
-  // action.
-  EXPECT_EQ(1u, num_toolbar_items());
-  EXPECT_EQ(component_action_id(), GetActionIdAtIndex(0u));
-}
-
-TEST_F(ToolbarActionsModelUnitTest, MigratedComponentActionAddedWithPrefTrue) {
-  extensions::FeatureSwitch::ScopedOverride enable_redesign(
-      extensions::FeatureSwitch::extension_action_redesign(), true);
-  InitForMigrationTest(MigrationStatus::FEATURE_ENABLED_WITH_PREF_TRUE);
-
-  EXPECT_EQ(1u, num_toolbar_items());
-  EXPECT_EQ(component_action_id(), GetActionIdAtIndex(0u));
-}
-
-TEST_F(ToolbarActionsModelUnitTest, NoMigratedComponentActionWithPrefFalse) {
-  extensions::FeatureSwitch::ScopedOverride enable_redesign(
-      extensions::FeatureSwitch::extension_action_redesign(), true);
-  InitForMigrationTest(MigrationStatus::FEATURE_ENABLED_WITH_PREF_FALSE);
-
-  EXPECT_EQ(0u, num_toolbar_items());
-}
-
-TEST_F(ToolbarActionsModelUnitTest, MigrationFromComponentActionToExtension) {
-  extensions::FeatureSwitch::ScopedOverride enable_redesign(
-      extensions::FeatureSwitch::extension_action_redesign(), true);
-  InitForMigrationTest(MigrationStatus::FEATURE_DISABLED_WITH_PREF_TRUE);
-
-  // Initialization re-enables the extension and removes the migrated component
-  // action.
-  EXPECT_EQ(1u, num_toolbar_items());
-  EXPECT_EQ(browser_action_migrated()->id(), GetActionIdAtIndex(0u));
-}
-
-TEST_F(ToolbarActionsModelUnitTest,
-       MigrationToExtensionWithoutExtensionActionRedesign) {
-  InitForMigrationTest(MigrationStatus::FEATURE_DISABLED_WITH_PREF_TRUE);
-
-  // Initialization re-enables the extension.
-  EXPECT_EQ(1u, num_toolbar_items());
-  EXPECT_EQ(browser_action_migrated()->id(), GetActionIdAtIndex(0u));
-}