Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: chrome/browser/ui/toolbar/mock_component_toolbar_actions_factory.cc

Issue 2678083005: Remove extension-to-component migration mechanism (Closed)
Patch Set: Address Derek's comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/toolbar/mock_component_toolbar_actions_factory.h" 5 #include "chrome/browser/ui/toolbar/mock_component_toolbar_actions_factory.h"
6 6
7 #include "chrome/browser/ui/browser.h" 7 #include "chrome/browser/ui/browser.h"
8 #include "chrome/browser/ui/toolbar/test_toolbar_action_view_controller.h" 8 #include "chrome/browser/ui/toolbar/test_toolbar_action_view_controller.h"
9 #include "chrome/browser/ui/toolbar/toolbar_action_view_controller.h" 9 #include "chrome/browser/ui/toolbar/toolbar_action_view_controller.h"
10 #include "extensions/common/feature_switch.h" 10 #include "extensions/common/feature_switch.h"
11 11
12 // static 12 // static
13 const char MockComponentToolbarActionsFactory::kActionIdForTesting[] = 13 const char MockComponentToolbarActionsFactory::kActionIdForTesting[] =
14 "mock_action"; 14 "mock_action";
15 15
16 MockComponentToolbarActionsFactory::MockComponentToolbarActionsFactory( 16 MockComponentToolbarActionsFactory::MockComponentToolbarActionsFactory(
17 Browser* browser) 17 Browser* browser) {
18 : migrated_feature_enabled_(false) {
19 ComponentToolbarActionsFactory::SetTestingFactory(this); 18 ComponentToolbarActionsFactory::SetTestingFactory(this);
20 } 19 }
21 20
22 MockComponentToolbarActionsFactory::~MockComponentToolbarActionsFactory() { 21 MockComponentToolbarActionsFactory::~MockComponentToolbarActionsFactory() {
23 ComponentToolbarActionsFactory::SetTestingFactory(nullptr); 22 ComponentToolbarActionsFactory::SetTestingFactory(nullptr);
24 } 23 }
25 24
26 std::set<std::string> 25 std::set<std::string>
27 MockComponentToolbarActionsFactory::GetInitialComponentIds(Profile* profile) { 26 MockComponentToolbarActionsFactory::GetInitialComponentIds(Profile* profile) {
28 std::set<std::string> ids; 27 std::set<std::string> ids;
29 // kActionIdForTesting is installed by default if we are not testing 28 if (extensions::FeatureSwitch::extension_action_redesign()->IsEnabled())
30 // a migration scenario.
31 if (extensions::FeatureSwitch::extension_action_redesign()->IsEnabled() &&
32 migrated_extension_id_.empty()) {
33 ids.insert(kActionIdForTesting); 29 ids.insert(kActionIdForTesting);
34 }
35 return ids; 30 return ids;
36 } 31 }
37 32
38 std::unique_ptr<ToolbarActionViewController> 33 std::unique_ptr<ToolbarActionViewController>
39 MockComponentToolbarActionsFactory::GetComponentToolbarActionForId( 34 MockComponentToolbarActionsFactory::GetComponentToolbarActionForId(
40 const std::string& id, 35 const std::string& id,
41 Browser* browser, 36 Browser* browser,
42 ToolbarActionsBar* bar) { 37 ToolbarActionsBar* bar) {
43 DCHECK_EQ(kActionIdForTesting, id); 38 DCHECK_EQ(kActionIdForTesting, id);
44 return std::unique_ptr<ToolbarActionViewController>( 39 return base::MakeUnique<TestToolbarActionViewController>(
45 new TestToolbarActionViewController( 40 MockComponentToolbarActionsFactory::kActionIdForTesting);
46 MockComponentToolbarActionsFactory::kActionIdForTesting));
47 } 41 }
48
49 void MockComponentToolbarActionsFactory::RegisterComponentMigrations(
50 extensions::ComponentMigrationHelper* helper) const {
51 if (!migrated_extension_id_.empty()) {
52 helper->Register(kActionIdForTesting, migrated_extension_id_);
53 }
54 }
55
56 void MockComponentToolbarActionsFactory::HandleComponentMigrations(
57 extensions::ComponentMigrationHelper* helper,
58 Profile* profile) const {
59 if (migrated_extension_id_.empty())
60 return;
61
62 if (migrated_feature_enabled_) {
63 helper->OnFeatureEnabled(kActionIdForTesting);
64 } else {
65 helper->OnFeatureDisabled(kActionIdForTesting);
66 }
67 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698