Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Side by Side Diff: chrome/browser/ui/toolbar/media_router_contextual_menu.cc

Issue 2678083005: Remove extension-to-component migration mechanism (Closed)
Patch Set: Address Derek's comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/toolbar/media_router_contextual_menu.h" 5 #include "chrome/browser/ui/toolbar/media_router_contextual_menu.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/metrics/user_metrics.h" 10 #include "base/metrics/user_metrics.h"
11 #include "chrome/app/chrome_command_ids.h" 11 #include "chrome/app/chrome_command_ids.h"
12 #include "chrome/browser/extensions/component_migration_helper.h"
13 #include "chrome/browser/media/router/media_router_factory.h" 12 #include "chrome/browser/media/router/media_router_factory.h"
14 #include "chrome/browser/media/router/mojo/media_router_mojo_impl.h" 13 #include "chrome/browser/media/router/mojo/media_router_mojo_impl.h"
15 #include "chrome/browser/profiles/profile.h" 14 #include "chrome/browser/profiles/profile.h"
16 #include "chrome/browser/signin/signin_manager_factory.h" 15 #include "chrome/browser/signin/signin_manager_factory.h"
17 #include "chrome/browser/ui/browser.h" 16 #include "chrome/browser/ui/browser.h"
18 #include "chrome/browser/ui/singleton_tabs.h" 17 #include "chrome/browser/ui/singleton_tabs.h"
19 #include "chrome/browser/ui/toolbar/component_toolbar_actions_factory.h" 18 #include "chrome/browser/ui/toolbar/component_toolbar_actions_factory.h"
20 #include "chrome/browser/ui/toolbar/media_router_action_controller.h" 19 #include "chrome/browser/ui/toolbar/media_router_action_controller.h"
21 #include "chrome/browser/ui/toolbar/toolbar_actions_model.h" 20 #include "chrome/browser/ui/toolbar/toolbar_actions_model.h"
22 #include "chrome/common/pref_names.h" 21 #include "chrome/common/pref_names.h"
23 #include "chrome/common/url_constants.h" 22 #include "chrome/common/url_constants.h"
24 #include "chrome/grit/chromium_strings.h" 23 #include "chrome/grit/chromium_strings.h"
25 #include "chrome/grit/generated_resources.h" 24 #include "chrome/grit/generated_resources.h"
26 #include "components/signin/core/browser/signin_manager.h" 25 #include "components/signin/core/browser/signin_manager.h"
27 #include "extensions/common/constants.h" 26 #include "extensions/common/constants.h"
28 #include "ui/base/models/menu_model_delegate.h" 27 #include "ui/base/models/menu_model_delegate.h"
29 #include "ui/gfx/color_palette.h" 28 #include "ui/gfx/color_palette.h"
30 #include "ui/gfx/paint_vector_icon.h" 29 #include "ui/gfx/paint_vector_icon.h"
31 30
32 MediaRouterContextualMenu::MediaRouterContextualMenu(Browser* browser) 31 MediaRouterContextualMenu::MediaRouterContextualMenu(Browser* browser)
33 : MediaRouterContextualMenu( 32 : MediaRouterContextualMenu(
34 browser, 33 browser,
35 MediaRouterActionController::IsActionShownByPolicy( 34 MediaRouterActionController::IsActionShownByPolicy(
36 browser->profile())) {} 35 browser->profile())) {}
37 36
38 MediaRouterContextualMenu::MediaRouterContextualMenu(Browser* browser, 37 MediaRouterContextualMenu::MediaRouterContextualMenu(Browser* browser,
39 bool shown_by_policy) 38 bool shown_by_policy)
40 : browser_(browser), 39 : browser_(browser), menu_model_(this) {
41 menu_model_(this),
42 component_migration_helper_(ToolbarActionsModel::Get(browser->profile())
43 ->component_migration_helper()) {
44 DCHECK(component_migration_helper_);
45
46 menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_ABOUT, 40 menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_ABOUT,
47 IDS_MEDIA_ROUTER_ABOUT); 41 IDS_MEDIA_ROUTER_ABOUT);
48 menu_model_.AddSeparator(ui::NORMAL_SEPARATOR); 42 menu_model_.AddSeparator(ui::NORMAL_SEPARATOR);
49 menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_LEARN_MORE, 43 menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_LEARN_MORE,
50 IDS_MEDIA_ROUTER_LEARN_MORE); 44 IDS_MEDIA_ROUTER_LEARN_MORE);
51 menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_HELP, 45 menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_HELP,
52 IDS_MEDIA_ROUTER_HELP); 46 IDS_MEDIA_ROUTER_HELP);
53 if (shown_by_policy) { 47 if (shown_by_policy) {
54 menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_SHOWN_BY_POLICY, 48 menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_SHOWN_BY_POLICY,
55 IDS_MEDIA_ROUTER_SHOWN_BY_POLICY); 49 IDS_MEDIA_ROUTER_SHOWN_BY_POLICY);
(...skipping 13 matching lines...) Expand all
69 #endif 63 #endif
70 menu_model_.AddCheckItemWithStringId(IDC_MEDIA_ROUTER_CLOUD_SERVICES_TOGGLE, 64 menu_model_.AddCheckItemWithStringId(IDC_MEDIA_ROUTER_CLOUD_SERVICES_TOGGLE,
71 IDS_MEDIA_ROUTER_CLOUD_SERVICES_TOGGLE); 65 IDS_MEDIA_ROUTER_CLOUD_SERVICES_TOGGLE);
72 menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_REPORT_ISSUE, 66 menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_REPORT_ISSUE,
73 IDS_MEDIA_ROUTER_REPORT_ISSUE); 67 IDS_MEDIA_ROUTER_REPORT_ISSUE);
74 } 68 }
75 69
76 MediaRouterContextualMenu::~MediaRouterContextualMenu() {} 70 MediaRouterContextualMenu::~MediaRouterContextualMenu() {}
77 71
78 bool MediaRouterContextualMenu::GetAlwaysShowActionPref() const { 72 bool MediaRouterContextualMenu::GetAlwaysShowActionPref() const {
79 return component_migration_helper_->GetComponentActionPref( 73 return MediaRouterActionController::GetAlwaysShowActionPref(
80 ComponentToolbarActionsFactory::kMediaRouterActionId); 74 browser_->profile());
81 } 75 }
82 76
83 void MediaRouterContextualMenu::SetAlwaysShowActionPref(bool always_show) { 77 void MediaRouterContextualMenu::SetAlwaysShowActionPref(bool always_show) {
84 component_migration_helper_->SetComponentActionPref( 78 return MediaRouterActionController::SetAlwaysShowActionPref(
85 ComponentToolbarActionsFactory::kMediaRouterActionId, always_show); 79 browser_->profile(), always_show);
86 } 80 }
87 81
88 bool MediaRouterContextualMenu::IsCommandIdChecked(int command_id) const { 82 bool MediaRouterContextualMenu::IsCommandIdChecked(int command_id) const {
89 if (command_id == IDC_MEDIA_ROUTER_CLOUD_SERVICES_TOGGLE) { 83 if (command_id == IDC_MEDIA_ROUTER_CLOUD_SERVICES_TOGGLE) {
90 return browser_->profile()->GetPrefs()->GetBoolean( 84 return browser_->profile()->GetPrefs()->GetBoolean(
91 prefs::kMediaRouterEnableCloudServices); 85 prefs::kMediaRouterEnableCloudServices);
92 } 86 }
93 if (command_id == IDC_MEDIA_ROUTER_ALWAYS_SHOW_TOOLBAR_ACTION) 87 if (command_id == IDC_MEDIA_ROUTER_ALWAYS_SHOW_TOOLBAR_ACTION)
94 return GetAlwaysShowActionPref(); 88 return GetAlwaysShowActionPref();
95 return false; 89 return false;
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 media_router::MediaRouterFactory::GetApiForBrowserContext( 159 media_router::MediaRouterFactory::GetApiForBrowserContext(
166 static_cast<content::BrowserContext*>(browser_->profile()))); 160 static_cast<content::BrowserContext*>(browser_->profile())));
167 if (media_router->media_route_provider_extension_id().empty()) 161 if (media_router->media_route_provider_extension_id().empty())
168 return; 162 return;
169 std::string feedback_url(extensions::kExtensionScheme + 163 std::string feedback_url(extensions::kExtensionScheme +
170 std::string(url::kStandardSchemeSeparator) + 164 std::string(url::kStandardSchemeSeparator) +
171 media_router->media_route_provider_extension_id() + 165 media_router->media_route_provider_extension_id() +
172 "/feedback.html"); 166 "/feedback.html");
173 chrome::ShowSingletonTab(browser_, GURL(feedback_url)); 167 chrome::ShowSingletonTab(browser_, GURL(feedback_url));
174 } 168 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698